From: Conor Dooley <conor@kernel.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Jose Ramon San Buenaventura <jose.sanbuenaventura@analog.com>,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
linux-i2c@vger.kernel.org, Jean Delvare <jdelvare@suse.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com>
Subject: Re: [PATCH v3 2/2] hwmon: pmbus: adm1275: add adm1281 support
Date: Fri, 26 Apr 2024 18:01:18 +0100 [thread overview]
Message-ID: <20240426-emoticon-exemplary-a79b0dfad5ce@spud> (raw)
In-Reply-To: <1a2e6020-77d8-4299-87b0-e2b16dfb3f86@roeck-us.net>
[-- Attachment #1: Type: text/plain, Size: 758 bytes --]
On Thu, Apr 25, 2024 at 10:52:03AM -0700, Guenter Roeck wrote:
> On 4/25/24 00:09, Jose Ramon San Buenaventura wrote:
> > Adding support for adm1281 which is similar to adm1275
> >
> > Signed-off-by: Jose Ramon San Buenaventura <jose.sanbuenaventura@analog.com>
>
> Patch is fine, but we'll need to wait for Conor's feedback
> regarding the compatible fallback before I can apply it.
Oh, I didn't realise you were waiting for me. I had deleted the thread
from my queue given I had already acked the patch.
I'm not really a fan of the warn when IDs don't match thing though,
seems a bit unhelpful, unless you've running into scenarios where the
firmware tells you there's a device present but actually there's some
other incompatible one.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2024-04-26 17:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-25 7:09 [PATCH v3 0/2] Add adm1281 support Jose Ramon San Buenaventura
2024-04-25 7:09 ` [PATCH v3 1/2] dt-bindings: hwmon: adm1275: add adm1281 Jose Ramon San Buenaventura
2024-04-25 7:19 ` Conor Dooley
2024-04-25 13:34 ` Guenter Roeck
2024-04-28 17:02 ` Guenter Roeck
2024-04-25 7:09 ` [PATCH v3 2/2] hwmon: pmbus: adm1275: add adm1281 support Jose Ramon San Buenaventura
2024-04-25 17:52 ` Guenter Roeck
2024-04-26 17:01 ` Conor Dooley [this message]
2024-04-26 17:42 ` Guenter Roeck
2024-04-28 17:02 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240426-emoticon-exemplary-a79b0dfad5ce@spud \
--to=conor@kernel.org \
--cc=Delphine_CC_Chiu@wiwynn.com \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=jose.sanbuenaventura@analog.com \
--cc=krzk+dt@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).