From: Guenter Roeck <linux@roeck-us.net>
To: "Deucher, Alexander" <Alexander.Deucher@amd.com>,
Philippe L <flip101@gmail.com>,
"Koenig, Christian" <Christian.Koenig@amd.com>,
"Zhou, David(ChunMing)" <David1.Zhou@amd.com>
Cc: "linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>
Subject: Re: amdgpu creating fan attribute for integrated graphics
Date: Wed, 28 Nov 2018 12:00:31 -0800 [thread overview]
Message-ID: <4fac9995-cca2-48ad-0e65-badad14e0cde@roeck-us.net> (raw)
In-Reply-To: <BN6PR12MB180917C25343DCC507B3DB7BF7D10@BN6PR12MB1809.namprd12.prod.outlook.com>
On 11/28/18 10:53 AM, Deucher, Alexander wrote:
> I believe the attached patch should fix the issue.
>
There is also a power attribute which returns -EINVAL, plus if I remember
correctly some voltage attributes.
Guenter
>
> Alex
>
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
> *From:* Philippe L <flip101@gmail.com>
> *Sent:* Wednesday, November 28, 2018 11:20:38 AM
> *To:* Deucher, Alexander; Koenig, Christian; Zhou, David(ChunMing)
> *Cc:* Guenter Roeck; linux-hwmon@vger.kernel.org
> *Subject:* amdgpu creating fan attribute for integrated graphics
> Hello,
>
> I'm writing to you after discussing a fancontrol issue on the lm-sensors issue tracker. I have a AMD Ryzen 5 2400G APU (with integrated graphics). The amdgpu driver is loaded and also creates a fan1_input attribute. However there is no separate GPU fan, there is only the CPU (APU) fan which is controlled by the motherboard. The fan1_input also seems to give some invalid readouts. I have not yet reached the bottom of this investigation, but so far my conclusion is that this causes fancontrol to choke up.
>
> Specifically the comment by Guenter Roeck here https://github.com/lm-sensors/lm-sensors/issues/144#issuecomment-442165451 describes the findings regarding the amdgpu driver.
>
> I'm writing to notify you about this problem, perhaps there can be some improvement in the amdgpu driver. I'm not really knowledgeable to discuss the workings of these drivers but i can provide debug output if needed.
>
> Best regards,
> Philippe
prev parent reply other threads:[~2018-11-29 7:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-28 16:20 amdgpu creating fan attribute for integrated graphics Philippe L
[not found] ` <BN6PR12MB180917C25343DCC507B3DB7BF7D10@BN6PR12MB1809.namprd12.prod.outlook.com>
2018-11-28 20:00 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4fac9995-cca2-48ad-0e65-badad14e0cde@roeck-us.net \
--to=linux@roeck-us.net \
--cc=Alexander.Deucher@amd.com \
--cc=Christian.Koenig@amd.com \
--cc=David1.Zhou@amd.com \
--cc=flip101@gmail.com \
--cc=linux-hwmon@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).