From: Max <max@enpas.org>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: linux-i2c@vger.kernel.org, linux-hwmon@vger.kernel.org,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org,
glaubitz@physik.fu-berlin.de
Subject: Re: [PATCH v2 1/4] i2c/busses: Add i2c-icy for I2C on m68k/Amiga
Date: Thu, 15 Aug 2019 13:52:47 +0200 [thread overview]
Message-ID: <54185c85-8c26-916e-41b1-af9b55223e7b@enpas.org> (raw)
In-Reply-To: <20190815114809.GA1916@kunai>
On 08/15/2019 01:48 PM, Wolfram Sang wrote:
>> Well, the other option is to remove it, and then add it back once
>> somebody complains - which is unlikely to happen. The clock parameter
>> is PCF8584 specific anyway, and I think removing it is a good option,
>
> My suggestion is to do that incrementally. First, get your driver
> accepted. Second, do the cleanups which affect elektor as well later.
My suggestion is to not touch i2c-elektor at all for now, and remove the 'clock' parameter from the first iteration of i2c-icy. It can be added back in case someone complains, which I deem unlikely.
>> as I've done the same with getown() (where in i2c-elektor, 'own' sets
>> the PCF8584's own address).
>
> I wondered about that. Can the PCF8584 really act as a slave, too?
> Somewhen I need to check its datasheet.
Yes it can, but this driver does not implement this.
In fact, I just remembered that the own address, while set, is not used at all in master mode!
Quote from the datasheet:
https://www.nxp.com/docs/en/data-sheet/PCF8584.pdf
6.4 Own address register S0'
When the PCF8584 is addressed as slave, this register
must be loaded with the 7-bit I 2 C-bus address to which the
PCF8584 is to respond. During initialization, the own
address register S0' must be written to, regardless
whether it is later used.
>> Question is, if I remove the parameter, I'd like it to be
>> non-destructive. Do you know of anything that can go wrong if the I2C
>> master is running the bus on a wrong clock?
>
> Not sure if I understand you correctly, but if the bus freq is too fast
> then devices won't respond. Too slow is not a problem.
Okay, so we don't care. Cool, then it's safe to kick the 'clock' parameter from i2c-icy. All 2019 boards (which should be the vast majority in existence) came with a 12 MHz oscillator AFAIK, so the default should be good.
Max
next prev parent reply other threads:[~2019-08-15 11:52 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-12 23:52 [PATCH v2 1/4] i2c/busses: Add i2c-icy for I2C on m68k/Amiga Max Staudt
2019-08-12 23:52 ` [PATCH v2 2/4] i2c/busses/i2c-icy: Add LTC2990 present on 2019 board revision Max Staudt
2019-08-13 7:03 ` Geert Uytterhoeven
2019-08-13 9:49 ` Max Staudt
2019-08-14 19:52 ` Wolfram Sang
2019-08-12 23:52 ` [PATCH v2 3/4] hwmon/ltc2990: Add platform_data support Max Staudt
2019-08-13 6:59 ` Geert Uytterhoeven
2019-08-13 8:02 ` Guenter Roeck
2019-08-13 8:27 ` Geert Uytterhoeven
2019-08-13 13:27 ` Guenter Roeck
2019-08-13 13:32 ` Geert Uytterhoeven
2019-08-13 10:10 ` Max Staudt
2019-08-13 13:24 ` Guenter Roeck
2019-08-13 13:31 ` Max
2019-08-14 18:11 ` Max Staudt
2019-08-12 23:52 ` [PATCH v2 4/4] i2c/busses/i2c-icy: Add platform_data for LTC2990 Max Staudt
2019-08-13 7:04 ` Geert Uytterhoeven
2019-08-13 7:08 ` [PATCH v2 1/4] i2c/busses: Add i2c-icy for I2C on m68k/Amiga Geert Uytterhoeven
2019-08-13 9:50 ` Max Staudt
2019-08-14 19:47 ` Wolfram Sang
2019-08-14 22:33 ` Max Staudt
2019-08-15 7:12 ` Wolfram Sang
2019-08-15 10:00 ` Max Staudt
2019-08-15 11:48 ` Wolfram Sang
2019-08-15 11:52 ` Max [this message]
2019-08-15 12:04 ` Wolfram Sang
2019-08-15 12:10 ` Max Staudt
2019-08-15 12:52 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54185c85-8c26-916e-41b1-af9b55223e7b@enpas.org \
--to=max@enpas.org \
--cc=glaubitz@physik.fu-berlin.de \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=wsa+renesas@sang-engineering.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).