From: Stefan Wahren <stefan.wahren@i2se.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Kamil Debski <kamil@wypas.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Jean Delvare <jdelvare@suse.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC 1/3] dt-bindings: hwmon: Add tachometer interrupt to pwm-fan
Date: Wed, 30 Jan 2019 21:23:31 +0100 (CET) [thread overview]
Message-ID: <625436113.118199.1548879811777@email.ionos.de> (raw)
In-Reply-To: <20190130172815.GC14781@roeck-us.net>
Hi Guenter,
> Guenter Roeck <linux@roeck-us.net> hat am 30. Januar 2019 um 18:28 geschrieben:
>
>
> On Wed, Jan 30, 2019 at 04:07:05PM +0100, Stefan Wahren wrote:
> > This adds the tachometer interrupt to the pwm-fan binding, which is
> > necessary for RPM support.
> >
> > Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> > ---
> > Documentation/devicetree/bindings/hwmon/pwm-fan.txt | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/hwmon/pwm-fan.txt b/Documentation/devicetree/bindings/hwmon/pwm-fan.txt
> > index 49ca5d8..7f69b0b 100644
> > --- a/Documentation/devicetree/bindings/hwmon/pwm-fan.txt
> > +++ b/Documentation/devicetree/bindings/hwmon/pwm-fan.txt
> > @@ -8,6 +8,9 @@ Required properties:
> >
> > Optional properties:
> > - fan-supply : phandle to the regulator that provides power to the fan
> > +- interrupts : contains a single interrupt specifier which describes the
> > + tachometer pin output of a 2 pulse-per-revolution fan.
> > + See interrupt-controller/interrupts.txt for the format.
>
> So a hypothetical {1,4} pulse-per-revolution fan would explicitly not be
> supported ? Why ?
i could add an additional property to specify the pulse per revolution and use the 2 as default (according to the Intel spec for 4 pin pwm fan) which should fit in most cases.
>
> Guenter
next prev parent reply other threads:[~2019-01-30 20:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-30 15:07 [PATCH RFC 0/3] hwmon: pwm-fan: Add RPM support Stefan Wahren
2019-01-30 15:07 ` [PATCH RFC 1/3] dt-bindings: hwmon: Add tachometer interrupt to pwm-fan Stefan Wahren
2019-01-30 17:28 ` Guenter Roeck
2019-01-30 20:23 ` Stefan Wahren [this message]
2019-01-30 20:35 ` Guenter Roeck
2019-01-31 8:02 ` Stefan Wahren
2019-01-31 17:19 ` Guenter Roeck
2019-01-30 15:07 ` [PATCH RFC 2/3] Documentation: pwm-fan: Add description for RPM support Stefan Wahren
2019-01-30 15:07 ` [PATCH RFC 3/3] hwmon: pwm-fan: Add RPM support via external interrupt Stefan Wahren
2019-01-31 17:40 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=625436113.118199.1548879811777@email.ionos.de \
--to=stefan.wahren@i2se.com \
--cc=b.zolnierkie@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=kamil@wypas.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).