From: Ruslan Babayev <ruslan@babayev.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Ruslan Babayev <ruslan@babayev.com>,
Jean Delvare <jdelvare@suse.com>,
xe-linux-external@cisco.com, Jonathan Corbet <corbet@lwn.net>,
linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] hwmon: (pmbus) add support for IR35215
Date: Tue, 16 Apr 2019 19:04:59 -0700 [thread overview]
Message-ID: <87zhopcrp0.fsf@babayev.com> (raw)
In-Reply-To: <20190416201603.GA25257@roeck-us.net>
Guenter Roeck writes:
>> +
>> +#include <linux/kernel.h>
>> +#include <linux/module.h>
>> +#include <linux/init.h>
>> +#include <linux/err.h>
>> +#include <linux/i2c.h>
>
> Alphabetic include file order please.
Sure
>> +
>> +static struct pmbus_driver_info ir3570b_info = {
>> + .pages = 1,
>
> Either this ...
>
>> + .format[PSC_VOLTAGE_IN] = linear,
>> + .format[PSC_VOLTAGE_OUT] = linear,
>> + .format[PSC_CURRENT_IN] = linear,
>> + .format[PSC_CURRENT_OUT] = linear,
>> + .format[PSC_POWER] = linear,
>> + .format[PSC_TEMPERATURE] = linear,
>> + .func[0] = IR3570B_FUNCS,
>> + .func[1] = IR3570B_FUNCS,
>
> ... or this is wrong.
The latter is wrong. Thanks for catching it.
next prev parent reply other threads:[~2019-04-17 2:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-16 18:36 [PATCH 3/4] hwmon: (pmbus) add support for IR35215 Ruslan Babayev
2019-04-16 20:16 ` Guenter Roeck
2019-04-17 2:04 ` Ruslan Babayev [this message]
2019-04-16 18:45 Ruslan Babayev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zhopcrp0.fsf@babayev.com \
--to=ruslan@babayev.com \
--cc=corbet@lwn.net \
--cc=jdelvare@suse.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=xe-linux-external@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).