From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DAD5C3A589 for ; Tue, 20 Aug 2019 09:08:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5DD4C22CF5 for ; Tue, 20 Aug 2019 09:08:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728771AbfHTJIN (ORCPT ); Tue, 20 Aug 2019 05:08:13 -0400 Received: from mail-oi1-f194.google.com ([209.85.167.194]:43938 "EHLO mail-oi1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728414AbfHTJIM (ORCPT ); Tue, 20 Aug 2019 05:08:12 -0400 Received: by mail-oi1-f194.google.com with SMTP id y8so3538197oih.10; Tue, 20 Aug 2019 02:08:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lrFXPnKUiQnk8Bn/RsYkWMYxjLa4oQsr3R8Oeq6EX1s=; b=jNxCReY4r+Yzgq5KZJJAondmbM1zWmzH9F5XLjfUK1fTADON+XVotH3VoCy753rH80 AnuGtNq2RvK3b5otBJDC+gl8vqK+Iqpq4MCG7A521HAgKqrPdHovmVw89estjx1tqsRp 86OffQetyfd4TkbPm3AP/RUsfntu/FXtr+3mW7bWJkIXVFiYbuvqmXCdhh/Vv7MIhgpb jaqdvFAusoXLhuNMTbwgB6xcSV+GUGxcCQQ6EzZV1j5rfyLlcCQf5z2PK/MGEbH/N0g3 QQbb6V8pHyOIetBk/vvYFUpbGMjCWaRFFSUyhO+esZHD/RBGUUhRz+f1XwyTjx9AXzxS g6tQ== X-Gm-Message-State: APjAAAUzNb7nzBMa+HF7Jfwr5k1C8MUU4z6Bk5qjG6+7suhYH8FiDaak ePfFN4QCqaK/NQH5mFmz72+E0w/Iu/048PWbi8k= X-Google-Smtp-Source: APXvYqyrME+Zi0KuuED6kPm+wXg4w60IHWQKF9jQ25MFaOMMjU5Ia1602KDn3l1GQS3FIFbsDmPgThd7qFVbcrP2XBk= X-Received: by 2002:a54:478d:: with SMTP id o13mr16391135oic.54.1566292091580; Tue, 20 Aug 2019 02:08:11 -0700 (PDT) MIME-Version: 1.0 References: <20190819121618.16557-1-max@enpas.org> In-Reply-To: <20190819121618.16557-1-max@enpas.org> From: Geert Uytterhoeven Date: Tue, 20 Aug 2019 11:08:00 +0200 Message-ID: Subject: Re: [PATCH v5 1/3] i2c/busses: Add i2c-icy for I2C on m68k/Amiga To: Max Staudt Cc: Linux I2C , linux-hwmon@vger.kernel.org, Wolfram Sang , Jean Delvare , Guenter Roeck , "Linux/m68k" , Linux Kernel Mailing List , John Paul Adrian Glaubitz Content-Type: text/plain; charset="UTF-8" Sender: linux-hwmon-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org On Mon, Aug 19, 2019 at 2:17 PM Max Staudt wrote: > This is the i2c-icy driver for the ICY board for Amiga computers. > It connects a PCF8584 I2C controller to the Zorro bus, providing I2C > connectivity. The original documentation can be found on Aminet: > > https://aminet.net/package/docs/hard/icy > > IRQ support is currently not implemented, as i2c-algo-pcf is built for > the ISA bus and a straight implementation of the same stack locks up a > Zorro machine. > > v5: usleep_range() instead of udelay() > Style > > v3: Fixed %pa format string > Dropped adapter class. > Clarified licence. > Removed clock parameter. > > v2: Matched function names to callbacks from i2c-algo-pcf > Used z_readb()/z_writeb() > Removed BROKEN_ON_SMP in Kconfig > Moved LTC2990 to a separate commit > > Signed-off-by: Max Staudt Reviewed-by: Geert Uytterhoeven > --- /dev/null > +++ b/drivers/i2c/busses/i2c-icy.c > +static int icy_pcf_getpcf(void *data, int ctl) > +{ > + struct icy_i2c *i2c = (struct icy_i2c *)data; > + > + u8 __iomem *address = ctl ? i2c->reg_s1 : i2c->reg_s0; > + int val = z_readb(address); > + > + return val; return z_readb(address); Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds