From: Thomas Gleixner <tglx@linutronix.de>
To: Eddie James <eajames@linux.vnet.ibm.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-doc@vger.kernel.org, Greg KH <gregkh@linuxfoundation.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
linux@roeck-us.net, jdelvare@suse.com,
Mark Rutland <mark.rutland@arm.com>,
openbmc@lists.ozlabs.org, robh+dt@kernel.org, joel@jms.id.au,
Kate Stewart <kstewart@linuxfoundation.org>
Subject: Re: [PATCH v4 9/9] hwmon (occ): Add sysfs attributes for additional OCC data
Date: Fri, 18 Jan 2019 01:43:52 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.21.1901180140150.1647@nanos.tec.linutronix.de> (raw)
In-Reply-To: <1531342898-15790-10-git-send-email-eajames@linux.vnet.ibm.com>
Eddie,
On Wed, 11 Jul 2018, Eddie James wrote:
> --- /dev/null
> +++ b/drivers/hwmon/occ/sysfs.c
> @@ -0,0 +1,188 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * OCC hwmon driver sysfs interface
> + *
> + * Copyright (C) IBM Corporation 2018
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + */
The above license information is inconsistent.
The SPDX license identifier says GPL v2 only, but the license notice says
GPL v2 or later. This is just wrong.
Please decide which one to use and please also remove the boiler plate
text. It is redundant.
See Documentation/process/license-rules.rst
Please fix ASAP.
Thanks,
tglx
next prev parent reply other threads:[~2019-01-18 0:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-11 21:01 [PATCH v4 0/9] hwmon and fsi: Add On-Chip Controller (OCC) driver Eddie James
2018-07-11 21:01 ` [PATCH v4 1/9] " Eddie James
2018-07-25 16:19 ` Guenter Roeck
2018-07-11 21:01 ` [PATCH v4 2/9] Documentation: hwmon: Add OCC documentation Eddie James
2018-07-25 16:36 ` Guenter Roeck
2018-08-30 21:29 ` Eddie James
2018-07-11 21:01 ` [PATCH v4 3/9] dt-bindings: i2c: Add P8 OCC hwmon device documentation Eddie James
2018-07-11 21:01 ` [PATCH v4 4/9] hwmon: Add On-Chip Controller (OCC) hwmon driver Eddie James
2018-07-11 21:01 ` [PATCH v4 5/9] hwmon (occ): Add command transport method for P8 and P9 Eddie James
2018-07-11 21:01 ` [PATCH v4 6/9] hwmon (occ): Parse OCC poll response Eddie James
2018-07-11 21:01 ` [PATCH v4 7/9] hwmon (occ): Add sensor types and versions Eddie James
2018-07-11 21:01 ` [PATCH v4 8/9] hwmon (occ): Add sensor attributes and register hwmon device Eddie James
2018-07-11 21:01 ` [PATCH v4 9/9] hwmon (occ): Add sysfs attributes for additional OCC data Eddie James
2019-01-18 0:43 ` Thomas Gleixner [this message]
2019-01-18 1:47 ` Joel Stanley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1901180140150.1647@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=benh@kernel.crashing.org \
--cc=devicetree@vger.kernel.org \
--cc=eajames@linux.vnet.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=jdelvare@suse.com \
--cc=joel@jms.id.au \
--cc=kstewart@linuxfoundation.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).