linux-hwmon.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eddie James <eajames@linux.vnet.ibm.com>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>,
	Jean Delvare <jdelvare@suse.com>,
	Guenter Roeck <linux@roeck-us.net>
Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hwmon (occ): Fix potential integer overflow
Date: Mon, 7 Jan 2019 12:43:31 -0600	[thread overview]
Message-ID: <c77ba012-e793-a4c0-00d5-90d4faa3d72a@linux.vnet.ibm.com> (raw)
In-Reply-To: <20190107183431.GA12428@embeddedor>



On 01/07/2019 12:34 PM, Gustavo A. R. Silva wrote:
> Cast get_unaligned_be32(...) to u64 in order to give the compiler
> complete information about the proper arithmetic to use and avoid
> a potential integer overflow.
>
> Notice that such function call is used in contexts that expect
> expressions of type u64 (64 bits, unsigned); and the following
> expressions are currently being evaluated using 32-bit
> arithmetic:
>
> val = get_unaligned_be32(&power->update_tag) *
>                          occ->powr_sample_time_us;
>
> val = get_unaligned_be32(&power->vdn.update_tag) *
>                          occ->powr_sample_time_us;

Thanks,

Reviewed-by: Eddie James <eajames@linux.ibm.com>

>
> Addresses-Coverity-ID: 1442357 ("Unintentional integer overflow")
> Addresses-Coverity-ID: 1442476 ("Unintentional integer overflow")
> Addresses-Coverity-ID: 1442508 ("Unintentional integer overflow")
> Fixes: ff692d80b2e2 ("hwmon (occ): Add sensor types and versions")
> Cc: stable@vger.kernel.org
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
>   drivers/hwmon/occ/common.c | 24 ++++++++++++------------
>   1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/hwmon/occ/common.c b/drivers/hwmon/occ/common.c
> index 423903f87955..391118c8aae8 100644
> --- a/drivers/hwmon/occ/common.c
> +++ b/drivers/hwmon/occ/common.c
> @@ -380,8 +380,8 @@ static ssize_t occ_show_power_1(struct device *dev,
>   		val *= 1000000ULL;
>   		break;
>   	case 2:
> -		val = get_unaligned_be32(&power->update_tag) *
> -			occ->powr_sample_time_us;
> +		val = (u64)get_unaligned_be32(&power->update_tag) *
> +			   occ->powr_sample_time_us;
>   		break;
>   	case 3:
>   		val = get_unaligned_be16(&power->value) * 1000000ULL;
> @@ -425,8 +425,8 @@ static ssize_t occ_show_power_2(struct device *dev,
>   				       &power->update_tag);
>   		break;
>   	case 2:
> -		val = get_unaligned_be32(&power->update_tag) *
> -			occ->powr_sample_time_us;
> +		val = (u64)get_unaligned_be32(&power->update_tag) *
> +			   occ->powr_sample_time_us;
>   		break;
>   	case 3:
>   		val = get_unaligned_be16(&power->value) * 1000000ULL;
> @@ -463,8 +463,8 @@ static ssize_t occ_show_power_a0(struct device *dev,
>   				       &power->system.update_tag);
>   		break;
>   	case 2:
> -		val = get_unaligned_be32(&power->system.update_tag) *
> -			occ->powr_sample_time_us;
> +		val = (u64)get_unaligned_be32(&power->system.update_tag) *
> +			   occ->powr_sample_time_us;
>   		break;
>   	case 3:
>   		val = get_unaligned_be16(&power->system.value) * 1000000ULL;
> @@ -477,8 +477,8 @@ static ssize_t occ_show_power_a0(struct device *dev,
>   				       &power->proc.update_tag);
>   		break;
>   	case 6:
> -		val = get_unaligned_be32(&power->proc.update_tag) *
> -			occ->powr_sample_time_us;
> +		val = (u64)get_unaligned_be32(&power->proc.update_tag) *
> +			   occ->powr_sample_time_us;
>   		break;
>   	case 7:
>   		val = get_unaligned_be16(&power->proc.value) * 1000000ULL;
> @@ -491,8 +491,8 @@ static ssize_t occ_show_power_a0(struct device *dev,
>   				       &power->vdd.update_tag);
>   		break;
>   	case 10:
> -		val = get_unaligned_be32(&power->vdd.update_tag) *
> -			occ->powr_sample_time_us;
> +		val = (u64)get_unaligned_be32(&power->vdd.update_tag) *
> +			   occ->powr_sample_time_us;
>   		break;
>   	case 11:
>   		val = get_unaligned_be16(&power->vdd.value) * 1000000ULL;
> @@ -505,8 +505,8 @@ static ssize_t occ_show_power_a0(struct device *dev,
>   				       &power->vdn.update_tag);
>   		break;
>   	case 14:
> -		val = get_unaligned_be32(&power->vdn.update_tag) *
> -			occ->powr_sample_time_us;
> +		val = (u64)get_unaligned_be32(&power->vdn.update_tag) *
> +			   occ->powr_sample_time_us;
>   		break;
>   	case 15:
>   		val = get_unaligned_be16(&power->vdn.value) * 1000000ULL;


  reply	other threads:[~2019-01-07 18:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-07 18:34 [PATCH] hwmon (occ): Fix potential integer overflow Gustavo A. R. Silva
2019-01-07 18:43 ` Eddie James [this message]
2019-01-07 19:32 ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c77ba012-e793-a4c0-00d5-90d4faa3d72a@linux.vnet.ibm.com \
    --to=eajames@linux.vnet.ibm.com \
    --cc=gustavo@embeddedor.com \
    --cc=jdelvare@suse.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).