Re: [PATCH v1 0/5] Help with lm75.c changes

[Iker Perez del Palomar <iker.perez@codethink.co.uk>]

Hi,


Thank you for offering to coach me!  You are right, I don't have
experience of writing kernel drivers at all.  I would like to be
coached by you.  I have a system with an tmp75b device to test with.

At the moment I haven't been given any project to work in. so I decided
to work in this driver.  We were using this driver and I wanted
to give a boost to it, while I learn more about the kernel drivers.
However I am open to any suggestions you might have, although If I am
given a new project I won't be able to work on this as much as now.

Thanks for your feedback and for offering to coach me,

Iker

On 09/07/2019 14:43, Guenter Roeck wrote:
> Hi,
> 
> On 7/9/19 2:50 AM, Iker Perez wrote:
>> From: Iker Perez del Palomar Sustatxa <iker.perez@codethink.co.uk>
>> 
>> Hello,
>> 
>> I have been working in the lm75.c driver, trying to add a variable
>>  update_time to the tmp75b device.
>> 
>> I am not very confident about, if what I am doing and how I am 
>> doing it is the best way it could be done. For that reason, I 
>> decided to send my current changes, so maybe I could be helped and 
>> my code revised.
>> 
>> I decided to separate my all my changes in probably more than 
>> needed commits because I thought that it would b easier to 
>> understand at first place. After the feedback and my changes are 
>> ready to submit I will squash the ones that are related between 
>> them and the patch series will be much shorter.
>> 
>> Thanks in advance for your help,
>> 
> 
> Looking through your patch series, I can't help thinking that you 
> don't have much experience writing kernel drivers. I am open to 
> coaching you through this, but I have to ask: Do you have an actual 
> use case ? This is not something we'll want to do as a coding 
> exercise, since it will add a non-trivial amount of code to the 
> kernel.
> 
> Thanks, Guenter
> 
>> Regards,
>> 
>> Iker
>> 
>> Iker Perez del Palomar Sustatxa (5): hwmon: (lm75) Add kind field 
>> to struct lm75_data hwmon: (lm75) Include hwmon_chip in the 
>> permitted types to be writen hwmon: (lm75) Give write permission
>> to hwmon_chip_update_interval hwmon: (lm75) Create function from
>> code to write into registers First approach to sample time writing
>>  method
>> 
>> drivers/hwmon/lm75.c | 166 
>> +++++++++++++++++++++++++++++++++------------------ 1 file
>> changed, 108 insertions(+), 58 deletions(-)
>> 
> 
> 

-- 
Iker Perez del Palomar, Software Engineer
Codethink Ltd                             35 Dale St, Manchester M1 2HF
http://www.codethink.co.uk/          Manchester, M1 2JW, United Kingdom
We respect your privacy.   See https://www.codethink.co.uk/privacy.html