From: 陈华才 <chenhc@lemote.com>
To: "Guenter Roeck" <linux@roeck-us.net>
Cc: "Jean Delvare" <jdelvare@suse.com>,
linux-hwmon <linux-hwmon@vger.kernel.org>,
"Fuxin Zhang" <zhangfx@lemote.com>,
"Yao Wang" <wangyao@lemote.com>
Subject: Re: [PATCH] hwmon: (w83795) temp4_type has writable permission
Date: Thu, 15 Nov 2018 16:11:10 +0800 [thread overview]
Message-ID: <tencent_73462BD43F9BC4D94258BB95@qq.com> (raw)
In-Reply-To: <20181115052320.GA5535@roeck-us.net>
Both datasheet and the comments of store_temp_mode() tell us that temp1~4 is writable, so fix it.
Huacai
------------------ Original ------------------
From: "Guenter Roeck"<linux@roeck-us.net>;
Date: Thu, Nov 15, 2018 01:23 PM
To: "Huacai Chen"<chenhc@lemote.com>;
Cc: "Jean Delvare"<jdelvare@suse.com>; "linux-hwmon"<linux-hwmon@vger.kernel.org>; "Fuxin Zhang"<zhangfx@lemote.com>; "Yao Wang"<wangyao@lemote.com>;
Subject: Re: [PATCH] hwmon: (w83795) temp4_type has writable permission
On Thu, Nov 15, 2018 at 10:44:57AM +0800, Huacai Chen wrote:
> Signed-off-by: Yao Wang <wangyao@lemote.com>
> Signed-off-by: Huacai Chen <chenhc@lemote.com>
Sorry, that really lacks context. Please add some details.
Guenter
> ---
> drivers/hwmon/w83795.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/w83795.c b/drivers/hwmon/w83795.c
> index 49276bb..1bb80f9 100644
> --- a/drivers/hwmon/w83795.c
> +++ b/drivers/hwmon/w83795.c
> @@ -1691,7 +1691,7 @@ store_sf_setup(struct device *dev, struct device_attribute *attr,
> * somewhere else in the code
> */
> #define SENSOR_ATTR_TEMP(index) { \
> - SENSOR_ATTR_2(temp##index##_type, S_IRUGO | (index < 4 ? S_IWUSR : 0), \
> + SENSOR_ATTR_2(temp##index##_type, S_IRUGO | (index < 5 ? S_IWUSR : 0), \
> show_temp_mode, store_temp_mode, NOT_USED, index - 1), \
> SENSOR_ATTR_2(temp##index##_input, S_IRUGO, show_temp, \
> NULL, TEMP_READ, index - 1), \
> --
> 2.7.0
>
next prev parent reply other threads:[~2018-11-15 18:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-15 2:44 [PATCH] hwmon: (w83795) temp4_type has writable permission Huacai Chen
2018-11-15 5:23 ` Guenter Roeck
2018-11-15 8:11 ` 陈华才 [this message]
2018-11-18 22:41 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_73462BD43F9BC4D94258BB95@qq.com \
--to=chenhc@lemote.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=wangyao@lemote.com \
--cc=zhangfx@lemote.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).