From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: "James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Guenter Roeck <linux@roeck-us.net>,
linux-scsi@vger.kernel.org, linux-ide@vger.kernel.org,
linux-hwmon@vger.kernel.org,
smartmontools-support@listi.jpberlin.de
Subject: Re: [PATCH v7] scsi: Add hwmon support for SMART temperature sensors
Date: Wed, 21 Nov 2018 12:28:46 -0500 [thread overview]
Message-ID: <yq1va4q8hm9.fsf@oracle.com> (raw)
In-Reply-To: <20181118193729.25278-1-linus.walleij@linaro.org> (Linus Walleij's message of "Sun, 18 Nov 2018 20:37:29 +0100")
Hi Linus!
> This driver does not block any simultaneous use of other SMART
> userspace tools, it's a both/and approach, not either/or.
The problem with all this is that the storage topology is largely
undiscoverable for monitoring purposes. We can use heuristics, but in
many cases there is no reliable way to find out that there is an ATA
device behind member #3 of a USB-attached RAID controller's virtual disk
#5.
So while I am sympathetic to providing this type of information inside
the kernel, the complexity of getting it right is mindboggling. Which is
why it currently lives in smartmontools in userland. And why even the
latter defers several of the topology decisions to the administrator.
You could then argue that the kernel should only provide sensors for a
trivial subset of configurations such as direct-attached ATA/SAS/USB
devices that provide sufficient heuristics to ensure we don't
accidentally send commands down that may wedge the device. I.e. repicate
smartmontools' heuristics inside the kernel. That's a valid position but
I remain unconvinced that it's worth it. Do you have specific user cases
other than this particular RAID box without enclosure sensors? (It's
also worth noting that HDD temperature sensors are notoriously
unreliable).
And finally, from an implementation perspective, both James and Doug
pointed you to SAT and the SCSI Temperature Log Page. libata is our
SAT. And thus the S.M.A.R.T. bits should be located in a libsmart
library that libata and USB can use to fill out the SCSI Temperature Log
Page. The hwmon-facing code would then use that log page instead of
dissecting S.M.A.R.T. information directly.
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2018-11-22 4:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-18 19:37 [PATCH v7] scsi: Add hwmon support for SMART temperature sensors Linus Walleij
2018-11-21 17:28 ` Martin K. Petersen [this message]
2018-11-22 13:49 ` Linus Walleij
2018-11-23 23:26 ` Martin K. Petersen
2018-11-27 2:39 ` [smartmontools-support] " Bruce Allen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1va4q8hm9.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=linus.walleij@linaro.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=smartmontools-support@listi.jpberlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).