From: Krzysztof Wilczynski <kswilczynski@gmail.com>
To: Haiyang Zhang <haiyangz@microsoft.com>
Cc: Krzysztof Wilczynski <kw@linux.com>,
Bjorn Helgaas <helgaas@kernel.org>,
KY Srinivasan <kys@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
Sasha Levin <sashal@kernel.org>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hyperv@vger.kernel.org
Subject: RE: [PATCH v2] PCI: hv: Make functions only used locally static in pci-hyperv.c
Date: Thu, 29 Aug 2019 02:08:29 +0200 [thread overview]
Message-ID: <1567037309.11524.1@gmail.com> (raw)
In-Reply-To: DM6PR21MB133796BB3D4A41278C513332CAA30@DM6PR21MB1337.namprd21.prod.outlook.com
Hello Haiyang,
Thank you for feedback.
[...]
> The second line should be aligned next to the "(" on the first line.
> Also the first line is now over 80 chars.
Sorry about this. I will fix it in v3. Thank you for pointing this
out.
To address both the alignment and line length of
hv_register_block_invalidate(),
I took a hint from the way how hv_compose_msi_req_v1() is current
formatted. I
hope that this would be acceptable.
Krzysztof
next prev parent reply other threads:[~2019-08-29 0:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-26 15:41 [PATCH] PCI: hv: Make functions only used locally static in pci-hyperv.c Krzysztof Wilczynski
2019-08-28 22:18 ` [PATCH v2] " Krzysztof Wilczynski
2019-08-28 22:32 ` Haiyang Zhang
2019-08-29 0:08 ` Krzysztof Wilczynski [this message]
2019-08-29 9:17 ` [PATCH v3] PCI: hv: Make functions static Krzysztof Wilczynski
2019-08-29 15:50 ` Haiyang Zhang
2019-09-04 14:27 ` Lorenzo Pieralisi
2019-09-04 14:36 ` Krzysztof Wilczynski
2019-08-28 22:26 ` [PATCH] PCI: hv: Make functions only used locally static in pci-hyperv.c Bjorn Helgaas
2019-08-28 23:33 ` Krzysztof Wilczynski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1567037309.11524.1@gmail.com \
--to=kswilczynski@gmail.com \
--cc=haiyangz@microsoft.com \
--cc=helgaas@kernel.org \
--cc=kw@linux.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=sashal@kernel.org \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).