From: David Miller <davem@davemloft.net>
To: lkmlabelt@gmail.com
Cc: kys@microsoft.com, haiyangz@microsoft.com,
sthemmin@microsoft.com, wei.liu@kernel.org,
linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org,
mikelley@microsoft.com, parri.andrea@gmail.com,
skarade@microsoft.com, kuba@kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] hv_netvsc: Add validation for untrusted Hyper-V values
Date: Thu, 30 Jul 2020 16:49:57 -0700 (PDT) [thread overview]
Message-ID: <20200730.164957.117753738942479389.davem@davemloft.net> (raw)
In-Reply-To: <20200728225321.26570-1-lkmlabelt@gmail.com>
From: Andres Beltran <lkmlabelt@gmail.com>
Date: Tue, 28 Jul 2020 18:53:21 -0400
> For additional robustness in the face of Hyper-V errors or malicious
> behavior, validate all values that originate from packets that Hyper-V
> has sent to the guest in the host-to-guest ring buffer. Ensure that
> invalid values cannot cause indexing off the end of an array, or
> subvert an existing validation via integer overflow. Ensure that
> outgoing packets do not have any leftover guest memory that has not
> been zeroed out.
>
> Cc: David S. Miller <davem@davemloft.net>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: netdev@vger.kernel.org
> Signed-off-by: Andres Beltran <lkmlabelt@gmail.com>
I need hyperv maintainer reviews before I will apply this.
Thank you.
next prev parent reply other threads:[~2020-07-30 23:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-28 22:53 [PATCH] hv_netvsc: Add validation for untrusted Hyper-V values Andres Beltran
2020-07-30 23:49 ` David Miller [this message]
2020-08-02 22:26 ` Haiyang Zhang
2020-08-14 10:39 ` Andrea Parri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200730.164957.117753738942479389.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=haiyangz@microsoft.com \
--cc=kuba@kernel.org \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkmlabelt@gmail.com \
--cc=mikelley@microsoft.com \
--cc=netdev@vger.kernel.org \
--cc=parri.andrea@gmail.com \
--cc=skarade@microsoft.com \
--cc=sthemmin@microsoft.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).