From: John Garry <john.garry@huawei.com>
To: Dexuan Cui <decui@microsoft.com>, <kys@microsoft.com>,
<sthemmin@microsoft.com>, <wei.liu@kernel.org>,
<jejb@linux.ibm.com>, <martin.petersen@oracle.com>,
<haiyangz@microsoft.com>, <ming.lei@redhat.com>,
<bvanassche@acm.org>, <linux-scsi@vger.kernel.org>,
<linux-hyperv@vger.kernel.org>, <longli@microsoft.com>,
<mikelley@microsoft.com>
Cc: <linux-kernel@vger.kernel.org>, <stable@vger.kernel.org>
Subject: Re: [PATCH v3] scsi: core: Fix shost->cmd_per_lun calculation in scsi_add_host_with_dma()
Date: Fri, 8 Oct 2021 13:00:25 +0100 [thread overview]
Message-ID: <8c87879b-ad28-e7bd-71ec-0c8a2ee99e7c@huawei.com> (raw)
In-Reply-To: <20211008043546.6006-1-decui@microsoft.com>
On 08/10/2021 05:35, Dexuan Cui wrote:
> After commit ea2f0f77538c, a 416-CPU VM running on Hyper-V hangs during
> boot because the hv_storvsc driver sets scsi_driver.can_queue to an "int"
> value that exceeds SHRT_MAX, and hence scsi_add_host_with_dma() sets
> shost->cmd_per_lun to a negative "short" value.
>
> Use min_t(int, ...) to fix the issue.
>
> Fixes: ea2f0f77538c ("scsi: core: Cap scsi_host cmd_per_lun at can_queue")
> Cc:stable@vger.kernel.org
> Signed-off-by: Dexuan Cui<decui@microsoft.com>
> Reviewed-by: Haiyang Zhang<haiyangz@microsoft.com>
> Reviewed-by: Ming Lei<ming.lei@redhat.com>
Reviewed-by: John Garry <john.garry@huawei.com>
thanks
next prev parent reply other threads:[~2021-10-08 11:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-08 4:35 [PATCH v3] scsi: core: Fix shost->cmd_per_lun calculation in scsi_add_host_with_dma() Dexuan Cui
2021-10-08 12:00 ` John Garry [this message]
2021-10-12 16:41 ` Martin K. Petersen
2021-10-12 18:05 ` Dexuan Cui
2021-10-12 21:27 ` Martin K. Petersen
2021-10-12 21:43 ` Dexuan Cui
2021-10-12 20:35 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c87879b-ad28-e7bd-71ec-0c8a2ee99e7c@huawei.com \
--to=john.garry@huawei.com \
--cc=bvanassche@acm.org \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=jejb@linux.ibm.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=longli@microsoft.com \
--cc=martin.petersen@oracle.com \
--cc=mikelley@microsoft.com \
--cc=ming.lei@redhat.com \
--cc=stable@vger.kernel.org \
--cc=sthemmin@microsoft.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).