From: Thomas Gleixner <tglx@linutronix.de>
To: lantianyu1986@gmail.com
Cc: pbonzini@redhat.com, rkrcmar@redhat.com, corbet@lwn.net,
kys@microsoft.com, haiyangz@microsoft.com,
sthemmin@microsoft.com, sashal@kernel.org, mingo@redhat.com,
bp@alien8.de, hpa@zytor.com, x86@kernel.org,
michael.h.kelley@microsoft.com,
Tianyu Lan <Tianyu.Lan@microsoft.com>,
kvm@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org,
vkuznets@redhat.com
Subject: Re: [PATCH V3 2/3] KVM/Hyper-V: Add new KVM cap KVM_CAP_HYPERV_DIRECT_TLBFLUSH
Date: Mon, 19 Aug 2019 15:27:51 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.1908191522390.2147@nanos.tec.linutronix.de> (raw)
In-Reply-To: <20190819131737.26942-3-Tianyu.Lan@microsoft.com>
On Mon, 19 Aug 2019, lantianyu1986@gmail.com wrote:
> From: Tianyu Lan <Tianyu.Lan@microsoft.com>
>
> This patch adds
Same git grep command as before
> new KVM cap KVM_CAP_HYPERV_DIRECT_TLBFLUSH and let
baseball cap? Please do not use weird acronyms. This is text and there is
not limitation on characters.
> user space to enable direct tlb flush function when only Hyper-V
> hypervsior capability is exposed to VM.
Sorry, but I'm not understanding this sentence.
> This patch also adds
Once more
> enable_direct_tlbflush callback in the struct kvm_x86_ops and
> platforms may use it to implement direct tlb flush support.
Please tell in the changelog WHY you are doing things not what. The what is
obviously in the patch.
So you want to explain what you are trying to achieve and why it is
useful. Then you can add a short note about what you are adding, but not at
the level of detail which is available from the diff itself.
Thanks,
tglx
next prev parent reply other threads:[~2019-08-19 13:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-19 13:17 [PATCH V3 0/3] KVM/Hyper-V: Add Hyper-V direct tlb flush support lantianyu1986
2019-08-19 13:17 ` [PATCH V3 1/3] x86/Hyper-V: Fix definition of struct hv_vp_assist_page lantianyu1986
2019-08-19 13:30 ` Thomas Gleixner
2019-08-19 13:17 ` [PATCH V3 2/3] KVM/Hyper-V: Add new KVM cap KVM_CAP_HYPERV_DIRECT_TLBFLUSH lantianyu1986
2019-08-19 13:27 ` Thomas Gleixner [this message]
2019-08-20 12:38 ` Tianyu Lan
2019-08-19 13:17 ` [PATCH V3 3/3] KVM/Hyper-V/VMX: Add direct tlb flush support lantianyu1986
2019-08-19 13:29 ` Thomas Gleixner
2019-08-27 6:41 ` [PATCH V3 0/3] KVM/Hyper-V: Add Hyper-V " Vitaly Kuznetsov
2019-08-27 12:17 ` Tianyu Lan
2019-08-27 12:33 ` Tianyu Lan
2019-08-27 12:38 ` Vitaly Kuznetsov
2019-08-27 13:07 ` Tianyu Lan
2019-08-27 13:29 ` Vitaly Kuznetsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1908191522390.2147@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=Tianyu.Lan@microsoft.com \
--cc=bp@alien8.de \
--cc=corbet@lwn.net \
--cc=haiyangz@microsoft.com \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=kys@microsoft.com \
--cc=lantianyu1986@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.h.kelley@microsoft.com \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=sashal@kernel.org \
--cc=sthemmin@microsoft.com \
--cc=vkuznets@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).