From: Qii Wang <qii.wang@mediatek.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: <linux-i2c@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>,
<srv_heupstream@mediatek.com>
Subject: Re: [PATCH] i2c: mediatek: Add i2c ac-timing adjust support
Date: Thu, 14 May 2020 09:15:05 +0800 [thread overview]
Message-ID: <1589418905.25512.10.camel@mhfsdcap03> (raw)
In-Reply-To: <20200512133852.GE13516@ninjato>
On Tue, 2020-05-12 at 15:38 +0200, Wolfram Sang wrote:
> Hi Qii Wang,
>
> On Thu, Mar 26, 2020 at 07:54:36PM +0800, qii.wang@mediatek.com wrote:
> > From: Qii Wang <qii.wang@mediatek.com>
> >
> > This patch adds a algorithm to calculate some ac-timing parameters
> > which can fully meet I2C Spec.
> >
> > Signed-off-by: Qii Wang <qii.wang@mediatek.com>
>
> Could you rebase this on top of i2c/for-next or v5.7-rcX? Because of
> commit 90224e6468e1 ("i2c: drivers: Use generic definitions for bus
> frequencies") which was added two days before your patch was sent out.
>
> Otherwise mostly minor nits.
>
> > +static int mtk_i2c_max_step_cnt(unsigned int target_speed)
> > +{
> > + if (target_speed > MAX_FS_MODE_SPEED)
> > + return MAX_HS_STEP_CNT_DIV;
> > + else
> > + return MAX_STEP_CNT_DIV;
> > +}
>
> Maybe ternary operator here? Your choice.
>
Use ternary operator here will over 80 bytes, and need a line break,
Maybe this code looks simpler.
> And my code checkers complained:
>
> CPPCHECK
> drivers/i2c/busses/i2c-mt65xx.c:591:11: warning: Redundant assignment of 'sda_max' to itself. [selfAssignment]
> sda_max = sda_max;
> ^
> drivers/i2c/busses/i2c-mt65xx.c:597:11: warning: Redundant assignment of 'sda_min' to itself. [selfAssignment]
> sda_min = sda_min;
>
ok, I will modify it.
> Last question: You seem to be the one doing major updates to this
> driver. Thanks for that! Are you maybe interested in becoming the
> maintainer for this driver? I think there won't be much patches to
> review and reports to handle but it will speed up processing for me.
>
Yes, It is my honor to be the maintainer for this driver.
> All the best,
>
> Wolfram
>
next prev parent reply other threads:[~2020-05-14 1:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-26 11:54 [PATCH] i2c: mediatek: Add i2c ac-timing adjust support qii.wang
2020-05-12 13:38 ` Wolfram Sang
2020-05-14 1:15 ` Qii Wang [this message]
2020-05-14 6:29 ` Wolfram Sang
2020-05-14 10:16 ` Qii Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1589418905.25512.10.camel@mhfsdcap03 \
--to=qii.wang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=srv_heupstream@mediatek.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).