From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
linux-i2c@vger.kernel.org, Wolfram Sang <wsa@the-dreams.de>
Subject: Re: [PATCH v1 1/4] i2c: designware: Split out i2c_dw_validate_speed() helper
Date: Tue, 19 May 2020 15:33:22 +0300 [thread overview]
Message-ID: <20200519123322.GG1634618@smile.fi.intel.com> (raw)
In-Reply-To: <c13ddaf2-5aef-e3fc-20ac-b1e0a9182fb0@linux.intel.com>
On Tue, May 12, 2020 at 06:12:32PM +0300, Jarkko Nikula wrote:
> On 5/11/20 4:42 PM, Andy Shevchenko wrote:
> > On Mon, May 11, 2020 at 04:11:57PM +0300, Jarkko Nikula wrote:
> > > On 5/7/20 4:51 PM, Andy Shevchenko wrote:
> > > > In order to export array supported speed for wider use,
> > > > split out them along with i2c_dw_validate_speed() helper.
...
> > > This header is included by every i2c-designware-*.c file and this inline
> > > function is not tiny. Would it be better to have this in
> > > i2c-designware-common.c instead?
> >
> > Yes, but then we will need to export i2c_dw_supported_speeds as well as its
> > array size.
> >
> Would that not be needed if you move ACPI parts also into
> i2c-designware-common.c?
Yes, in the intermediate patch. I'm about to send v2, where you may see how it
looks like.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2020-05-19 12:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-07 13:51 [PATCH v1 1/4] i2c: designware: Split out i2c_dw_validate_speed() helper Andy Shevchenko
2020-05-07 13:51 ` [PATCH v1 2/4] i2c: designware: Split out OF parts into separate module Andy Shevchenko
2020-05-07 13:51 ` [PATCH v1 3/4] i2c: designware: Split out ACPI " Andy Shevchenko
2020-05-11 13:31 ` Jarkko Nikula
2020-05-11 14:05 ` Andy Shevchenko
2020-05-07 13:51 ` [PATCH v1 4/4] i2c: designware: Read counters from ACPI for PCI driver Andy Shevchenko
2020-05-11 13:11 ` [PATCH v1 1/4] i2c: designware: Split out i2c_dw_validate_speed() helper Jarkko Nikula
2020-05-11 13:42 ` Andy Shevchenko
2020-05-12 15:12 ` Jarkko Nikula
2020-05-19 12:33 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200519123322.GG1634618@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).