From: <wsa@the-dreams.de>
To: Qii Wang <qii.wang@mediatek.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
<qiangming.xia@mediatek.com>, <devicetree@vger.kernel.org>,
<srv_heupstream@mediatek.com>, <leilk.liu@mediatek.com>,
<linux-kernel@vger.kernel.org>, <robh+dt@kernel.org>,
<linux-mediatek@lists.infradead.org>, <linux-i2c@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 2/4] i2c: mediatek: Add access to more than 8GB dram in i2c driver
Date: Wed, 5 Aug 2020 10:56:34 +0200 [thread overview]
Message-ID: <20200805085634.GF1229@kunai> (raw)
In-Reply-To: <1596010499.4371.3.camel@mhfsdcap03>
[-- Attachment #1: Type: text/plain, Size: 537 bytes --]
> > > -static inline u32 mtk_i2c_set_4g_mode(dma_addr_t addr)
> > > -{
> > > - return (addr & BIT_ULL(32)) ? I2C_DMA_4G_MODE : I2C_DMA_CLR_FLAG;
> >
> > I think you missed my comment in the last version:
> > I2C_DMA_4G_MODE is no longer needed, you can delete it.
> >
> > Regards,
> > Matthias
> >
>
> Sorry for missing that comment, I will remove it.
> Thank you for your comments and reminders.
If you send it real soon, I can still include it for 5.9.
(and please guys, shorten mails to the relevant parts)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-08-05 8:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-28 12:30 [PATCH v2 0/4] add i2c support for mt8192 Qii Wang
2020-07-28 12:30 ` [PATCH v2 1/4] i2c: mediatek: Add apdma sync in i2c driver Qii Wang
2020-07-28 12:30 ` [PATCH v2 2/4] i2c: mediatek: Add access to more than 8GB dram " Qii Wang
2020-07-29 7:59 ` Matthias Brugger
2020-07-29 8:14 ` Qii Wang
2020-08-05 8:56 ` wsa [this message]
2020-07-30 2:39 ` Yingjoe Chen
2020-07-28 12:30 ` [PATCH v2 3/4] dt-bindings: i2c: update bindings for MT8192 SoC Qii Wang
2020-07-28 12:30 ` [PATCH v2 4/4] i2c: mediatek: Add i2c compatible for MediaTek MT8192 Qii Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200805085634.GF1229@kunai \
--to=wsa@the-dreams.de \
--cc=devicetree@vger.kernel.org \
--cc=leilk.liu@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=qiangming.xia@mediatek.com \
--cc=qii.wang@mediatek.com \
--cc=robh+dt@kernel.org \
--cc=srv_heupstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).