From: Li Huafei <lihuafei1@huawei.com>
To: <orsonzhai@gmail.com>, <zhang.lyra@gmail.com>, <wsa@kernel.org>,
<zhengdejin5@gmail.com>, <linhua.xu@unisoc.com>,
<andriy.shevchenko@linux.intel.com>
Cc: <linux-i2c@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<yangjihong1@huawei.com>, <zhangjinhao2@huawei.com>,
<--lihuafei1@huawei.com>
Subject: [PATCH -next] i2c: sprd: Fix PM reference leak in sprd_i2c_master_xfer()
Date: Thu, 8 Apr 2021 20:59:15 +0800 [thread overview]
Message-ID: <20210408125915.137089-1-lihuafei1@huawei.com> (raw)
pm_runtime_get_sync will increment pm usage counter even it failed.
Forgetting to putting operation will result in reference leak here. Fix
it by replacing it with pm_runtime_resume_and_get to keep usage counter
balanced.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Li Huafei <lihuafei1@huawei.com>
---
drivers/i2c/busses/i2c-sprd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-sprd.c b/drivers/i2c/busses/i2c-sprd.c
index 2917fecf6c80..8ead7e021008 100644
--- a/drivers/i2c/busses/i2c-sprd.c
+++ b/drivers/i2c/busses/i2c-sprd.c
@@ -290,7 +290,7 @@ static int sprd_i2c_master_xfer(struct i2c_adapter *i2c_adap,
struct sprd_i2c *i2c_dev = i2c_adap->algo_data;
int im, ret;
- ret = pm_runtime_get_sync(i2c_dev->dev);
+ ret = pm_runtime_resume_and_get(i2c_dev->dev);
if (ret < 0)
return ret;
@@ -576,7 +576,7 @@ static int sprd_i2c_remove(struct platform_device *pdev)
struct sprd_i2c *i2c_dev = platform_get_drvdata(pdev);
int ret;
- ret = pm_runtime_get_sync(i2c_dev->dev);
+ ret = pm_runtime_resume_and_get(i2c_dev->dev);
if (ret < 0)
return ret;
--
2.17.1
next reply other threads:[~2021-04-08 12:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 12:59 Li Huafei [this message]
2021-04-14 8:01 ` [PATCH -next] i2c: sprd: Fix PM reference leak in sprd_i2c_master_xfer() Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210408125915.137089-1-lihuafei1@huawei.com \
--to=lihuafei1@huawei.com \
--cc=--lihuafei1@huawei.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linhua.xu@unisoc.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=orsonzhai@gmail.com \
--cc=wsa@kernel.org \
--cc=yangjihong1@huawei.com \
--cc=zhang.lyra@gmail.com \
--cc=zhangjinhao2@huawei.com \
--cc=zhengdejin5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).