From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-i2c@vger.kernel.org, Heiner Kallweit <hkallweit1@gmail.com>,
Peter Rosin <peda@axentia.se>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
"Rob Herring (Arm)" <robh@kernel.org>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] power: supply: sbs-manager: Remove class argument from i2c_mux_add_adapter()
Date: Mon, 13 May 2024 23:17:48 +0200 [thread overview]
Message-ID: <4g4u2g2nrcpjvx4uswxppw2vsfzwcsy6kbsjp7ukksgfyhgnqb@s5n6jlz6w7af> (raw)
In-Reply-To: <20240513201400.16589-2-wsa+renesas@sang-engineering.com>
[-- Attachment #1: Type: text/plain, Size: 1795 bytes --]
Hi Wolfram,
On Mon, May 13, 2024 at 10:11:16PM +0200, Wolfram Sang wrote:
> Commit 99a741aa7a2d ("i2c: mux: gpio: remove support for class-based
> device instantiation") removed the last call to i2c_mux_add_adapter()
> with a non-null class argument. Therefore the class argument can be
> removed.
>
> Note: Class-based device instantiation is a legacy mechanism which
> shouldn't be used in new code, so we can rule out that this argument
> may be needed again in the future.
>
> This driver was forgotten by the patch in the Fixes tag.
>
> Fixes: fec1982d7072 ("i2c: mux: Remove class argument from i2c_mux_add_adapter()")
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>
> The to-be-fixed patch is only in linux-next in my i2c/for-next tree. We
> want to remove this unneeded parameter in the next mergewindow. I
> suggest that I just put it on top of my branch to avoid the
> dependencies. A quick ack would be super-awesome! Thanks.
Acked-by: Sebastian Reichel <sebastian.reichel@collabora.com>
-- Sebastian
> drivers/power/supply/sbs-manager.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/supply/sbs-manager.c b/drivers/power/supply/sbs-manager.c
> index 9e4141cffbf9..933b04806d10 100644
> --- a/drivers/power/supply/sbs-manager.c
> +++ b/drivers/power/supply/sbs-manager.c
> @@ -358,7 +358,7 @@ static int sbsm_probe(struct i2c_client *client)
> /* register muxed i2c channels. One for each supported battery */
> for (i = 0; i < SBSM_MAX_BATS; ++i) {
> if (data->supported_bats & BIT(i)) {
> - ret = i2c_mux_add_adapter(data->muxc, 0, i + 1, 0);
> + ret = i2c_mux_add_adapter(data->muxc, 0, i + 1);
> if (ret)
> break;
> }
> --
> 2.43.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2024-05-13 21:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-13 20:11 [PATCH] power: supply: sbs-manager: Remove class argument from i2c_mux_add_adapter() Wolfram Sang
2024-05-13 21:17 ` Sebastian Reichel [this message]
2024-05-14 7:23 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4g4u2g2nrcpjvx4uswxppw2vsfzwcsy6kbsjp7ukksgfyhgnqb@s5n6jlz6w7af \
--to=sebastian.reichel@collabora.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=hkallweit1@gmail.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=peda@axentia.se \
--cc=robh@kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).