From: Yicong Yang <yangyicong@hisilicon.com>
To: Wolfram Sang <wsa@kernel.org>,
<andriy.shevchenko@linux.intel.com>, <linux-i2c@vger.kernel.org>,
<Sergey.Semin@baikalelectronics.ru>,
<linux-kernel@vger.kernel.org>, <digetx@gmail.com>,
<treding@nvidia.com>, <jarkko.nikula@linux.intel.com>,
<rmk+kernel@armlinux.org.uk>, <song.bao.hua@hisilicon.com>,
<john.garry@huawei.com>, <mika.westerberg@linux.intel.com>,
<prime.zeng@huawei.com>, <linuxarm@huawei.com>
Subject: Re: [PATCH v6 3/5] i2c: add support for HiSilicon I2C controller
Date: Wed, 7 Apr 2021 16:18:37 +0800 [thread overview]
Message-ID: <5c64a396-05ca-d19f-04ca-a3770e82c009@hisilicon.com> (raw)
In-Reply-To: <20210406200248.GH3122@kunai>
On 2021/4/7 4:02, Wolfram Sang wrote:
>
> Only super minor stuff. Thanks to all the contributors and reviewers!
>
>> +#define HZ_PER_KHZ 1000
>
> KHZ_PER_HZ?
that doesn't match what we want. we want the count of HZs per one KHZ.
>
>> + ret = devm_i2c_add_adapter(dev, adapter);
>> + if (ret) {
>> + dev_err(dev, "failed to add i2c adapter, ret = %d\n", ret);
>
> No need to print that. The core prints messages on failures.
>
i check the code and find a little difference. the print in the core doesn't
have the device prefix so it may not tell us which device's registeration fails.
but considering we have device name embedded in the adapter name for this
driver, it's ok to remove this message.
next prev parent reply other threads:[~2021-04-07 8:18 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-31 13:36 [PATCH v6 0/5] Add support for HiSilicon I2C controller Yicong Yang
2021-03-31 13:36 ` [PATCH v6 1/5] i2c: core: add managed function for adding i2c adapters Yicong Yang
2021-04-06 20:16 ` Wolfram Sang
2021-03-31 13:36 ` [PATCH v6 2/5] i2c: core: add api to provide frequency mode strings Yicong Yang
2021-04-06 19:54 ` Wolfram Sang
2021-04-07 8:29 ` Yicong Yang
2021-04-07 10:08 ` Andy Shevchenko
2021-04-07 10:24 ` Yicong Yang
2021-04-07 22:56 ` Wolfram Sang
2021-03-31 13:36 ` [PATCH v6 3/5] i2c: add support for HiSilicon I2C controller Yicong Yang
2021-04-06 20:02 ` Wolfram Sang
2021-04-07 8:18 ` Yicong Yang [this message]
2021-04-07 8:32 ` Jarkko Nikula
2021-04-07 10:16 ` Yicong Yang
2021-04-07 23:04 ` Wolfram Sang
2021-04-08 7:17 ` Yicong Yang
2021-04-08 9:43 ` Andy Shevchenko
2021-03-31 13:36 ` [PATCH v6 4/5] MAINTAINERS: Add maintainer for HiSilicon I2C driver Yicong Yang
2021-03-31 13:36 ` [PATCH v6 5/5] i2c: designware: Switch over to i2c_freq_mode_string() Yicong Yang
2021-04-06 20:18 ` [PATCH v6 0/5] Add support for HiSilicon I2C controller Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c64a396-05ca-d19f-04ca-a3770e82c009@hisilicon.com \
--to=yangyicong@hisilicon.com \
--cc=Sergey.Semin@baikalelectronics.ru \
--cc=andriy.shevchenko@linux.intel.com \
--cc=digetx@gmail.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=john.garry@huawei.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=mika.westerberg@linux.intel.com \
--cc=prime.zeng@huawei.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=song.bao.hua@hisilicon.com \
--cc=treding@nvidia.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).