From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: Wolfram Sang <wsa@kernel.org>, nicolas.vincent@vossloh.com
Cc: linuxppc-dev@lists.ozlabs.org, linux-i2c@vger.kernel.org
Subject: Re: [PATCH v2] i2c: cpm: Fix i2c_ram structure
Date: Wed, 23 Sep 2020 20:27:50 +0200 [thread overview]
Message-ID: <96cbd909-818e-c10b-9e10-68a39ea269e9@csgroup.eu> (raw)
In-Reply-To: <20200923160829.GB6697@ninjato>
Le 23/09/2020 à 18:08, Wolfram Sang a écrit :
> On Wed, Sep 23, 2020 at 04:08:40PM +0200, nico.vince@gmail.com wrote:
>> From: Nicolas VINCENT <nicolas.vincent@vossloh.com>
>>
>> the i2c_ram structure is missing the sdmatmp field mentionned in
>> datasheet for MPC8272 at paragraph 36.5. With this field missing, the
>> hardware would write past the allocated memory done through
>> cpm_muram_alloc for the i2c_ram structure and land in memory allocated
>> for the buffers descriptors corrupting the cbd_bufaddr field. Since this
>> field is only set during setup(), the first i2c transaction would work
>> and the following would send data read from an arbitrary memory
>> location.
>>
>> Signed-off-by: Nicolas VINCENT <nicolas.vincent@vossloh.com>
>
> Thanks!
>
> Is someone able to identify a Fixes: tag I could add?
I'd suggest
Fixes: 61045dbe9d8d ("i2c: Add support for I2C bus on Freescale
CPM1/CPM2 controllers")
Christophe
>
>> ---
>> drivers/i2c/busses/i2c-cpm.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/i2c/busses/i2c-cpm.c b/drivers/i2c/busses/i2c-cpm.c
>> index 1213e1932ccb..24d584a1c9a7 100644
>> --- a/drivers/i2c/busses/i2c-cpm.c
>> +++ b/drivers/i2c/busses/i2c-cpm.c
>> @@ -65,6 +65,9 @@ struct i2c_ram {
>> char res1[4]; /* Reserved */
>> ushort rpbase; /* Relocation pointer */
>> char res2[2]; /* Reserved */
>> + /* The following elements are only for CPM2 */
>> + char res3[4]; /* Reserved */
>> + uint sdmatmp; /* Internal */
>> };
>>
>> #define I2COM_START 0x80
>> --
>> 2.17.1
>>
next prev parent reply other threads:[~2020-09-23 18:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-23 14:08 [PATCH v2] i2c: cpm: Fix i2c_ram structure nico.vince
2020-09-23 14:12 ` Jochen Friedrich
2020-09-23 16:08 ` Wolfram Sang
2020-09-23 18:27 ` Christophe Leroy [this message]
2020-09-27 13:15 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96cbd909-818e-c10b-9e10-68a39ea269e9@csgroup.eu \
--to=christophe.leroy@csgroup.eu \
--cc=linux-i2c@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nicolas.vincent@vossloh.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).