From: Boris Brezillon <boris.brezillon@collabora.com>
To: Przemyslaw Gaj <pgaj@cadence.com>
Cc: linux-i3c@lists.infradead.org, vitor.soares@synopsys.com,
rafalc@cadence.com, agolec@cadence.com, bbrezillon@kernel.org
Subject: Re: [PATCH v4 0/4] Drop support for I2C 10 bit devices from I3C subsystem
Date: Tue, 16 Apr 2019 07:27:55 +0200 [thread overview]
Message-ID: <20190416072755.3605997d@collabora.com> (raw)
In-Reply-To: <20190416044146.2382-1-pgaj@cadence.com>
On Tue, 16 Apr 2019 05:41:42 +0100
Przemyslaw Gaj <pgaj@cadence.com> wrote:
> I3C MIPI spec does not clearly say that I2C 10bit devices are supported.
> Additionally, it isn't possible to pass 10 bit device properly through DEFSLVS
> command and reserve address for such device on secondary master side.
>
> Main changes between v3 and v4:
> - Fix changelogs
> - Fix patch versioning
> - Change order of the patches to make it bisectable.
>
> Przemyslaw Gaj (4):
> i3c: master: cdns: Drop support for I2C 10 bit addresing in Cadence
> I3C master
> i3c: master: dw-i3c-master: Remove i2c_funcs hook implementation
> i3c: Drop support for I2C 10 bit addresing
Sorry, but this is still breaking bisectability. If you run the kernel
after applying the first 2 patches you get a NULL pointer dereference.
Please merge patches 1 to 3 into a single patch, that's the simplest
solution.
> dt-bindings: i3c: Document dropped support for I2C 10 bit devices
>
> Documentation/devicetree/bindings/i3c/i3c.txt | 4 +++-
> drivers/i3c/master.c | 21 ++++++++++++++-------
> drivers/i3c/master/dw-i3c-master.c | 6 ------
> drivers/i3c/master/i3c-master-cdns.c | 10 +---------
> include/linux/i3c/master.h | 5 +----
> 5 files changed, 19 insertions(+), 27 deletions(-)
>
_______________________________________________
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
prev parent reply other threads:[~2019-04-16 5:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-16 4:41 [PATCH v4 0/4] Drop support for I2C 10 bit devices from I3C subsystem Przemyslaw Gaj
2019-04-16 4:41 ` [PATCH v4 1/4] i3c: master: cdns: Drop support for I2C 10 bit addresing in Cadence I3C master Przemyslaw Gaj
2019-04-16 4:41 ` [PATCH v4 2/4] i3c: master: dw-i3c-master: Remove i2c_funcs hook implementation Przemyslaw Gaj
2019-04-16 4:41 ` [PATCH v4 3/4] i3c: Drop support for I2C 10 bit addresing Przemyslaw Gaj
2019-04-16 4:41 ` [PATCH v4 4/4] dt-bindings: i3c: Document dropped support for I2C 10 bit devices Przemyslaw Gaj
2019-04-16 5:27 ` Boris Brezillon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190416072755.3605997d@collabora.com \
--to=boris.brezillon@collabora.com \
--cc=agolec@cadence.com \
--cc=bbrezillon@kernel.org \
--cc=linux-i3c@lists.infradead.org \
--cc=pgaj@cadence.com \
--cc=rafalc@cadence.com \
--cc=vitor.soares@synopsys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).