From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: linux-i2c@vger.kernel.org
Cc: devicetree@vger.kernel.org, "Jacopo Mondi" <jacopo@jmondi.org>,
"Niklas Söderlund" <niklas.soderlund@ragnatech.se>,
"Wolfram Sang" <wsa+renesas@sang-engineering.com>,
linux-kernel@vger.kernel.org, "Vladimir Zapolskiy" <vz@mleia.com>,
linux-renesas-soc@vger.kernel.org,
"Kieran Bingham" <kieran@bingham.xyz>,
"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
"Luca Ceresoli" <luca@lucaceresoli.net>,
linux-i3c@lists.infradead.org
Subject: [RFC PATCH 7/7] i2c: core: hand over reserved devices when requesting ancillary addresses
Date: Thu, 20 Feb 2020 18:24:03 +0100 [thread overview]
Message-ID: <20200220172403.26062-8-wsa+renesas@sang-engineering.com> (raw)
In-Reply-To: <20200220172403.26062-1-wsa+renesas@sang-engineering.com>
With i2c_new_ancillary_address, we can check if the intended driver is
requesting a reserved address. Update the function to do these checks.
If the check passes, the "reserved" device will become a regular "dummy"
device.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
drivers/i2c/i2c-core-base.c | 18 +++++++++++++++++-
1 file changed, 17 insertions(+), 1 deletion(-)
diff --git a/drivers/i2c/i2c-core-base.c b/drivers/i2c/i2c-core-base.c
index 4000a4384306..ba325f8107a3 100644
--- a/drivers/i2c/i2c-core-base.c
+++ b/drivers/i2c/i2c-core-base.c
@@ -975,6 +975,8 @@ struct i2c_client *i2c_new_ancillary_device(struct i2c_client *client,
u16 default_addr)
{
struct device_node *np = client->dev.of_node;
+ struct device *reserved_dev, *adapter_dev = &client->adapter->dev;
+ struct i2c_client *reserved_client;
u32 addr = default_addr;
int i;
@@ -984,7 +986,21 @@ struct i2c_client *i2c_new_ancillary_device(struct i2c_client *client,
of_property_read_u32_index(np, "reg", i, &addr);
}
- dev_dbg(&client->adapter->dev, "Address for %s : 0x%x\n", name, addr);
+ dev_info(adapter_dev, "Address for %s : 0x%x\n", name, addr);
+
+ /* No need to scan muxes, siblings must sit on the same adapter */
+ reserved_dev = device_find_child(adapter_dev, &addr, __i2c_check_addr_busy);
+ reserved_client = i2c_verify_client(reserved_dev);
+
+ if (reserved_client) {
+ if (reserved_client->dev.of_node != np ||
+ strcmp(reserved_client->name, I2C_RESERVED_DRV_NAME) != 0)
+ return ERR_PTR(-EBUSY);
+
+ strlcpy(reserved_client->name, I2C_DUMMY_DRV_NAME, sizeof(client->name));
+ return reserved_client;
+ }
+
return i2c_new_dummy_device(client->adapter, addr);
}
EXPORT_SYMBOL_GPL(i2c_new_ancillary_device);
--
2.20.1
_______________________________________________
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
next prev parent reply other threads:[~2020-02-20 17:26 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 17:23 [RFC PATCH 0/7] i2c: of: reserve unknown and ancillary addresses Wolfram Sang
2020-02-20 17:23 ` [RFC PATCH 1/7] i2c: add sanity check for parameter of i2c_verify_client() Wolfram Sang
2020-02-21 9:36 ` Geert Uytterhoeven
2020-02-20 17:23 ` [RFC PATCH 2/7] i2c: use DEFINE for the dummy driver name Wolfram Sang
2020-02-21 9:38 ` Geert Uytterhoeven
2020-02-20 17:23 ` [RFC PATCH 3/7] i2c: allow DT nodes without 'compatible' Wolfram Sang
2020-02-21 9:45 ` Geert Uytterhoeven
2020-02-21 9:48 ` Geert Uytterhoeven
2020-02-23 23:11 ` Luca Ceresoli
2020-03-12 11:19 ` Wolfram Sang
2020-03-12 11:44 ` Alexandre Belloni
2020-04-10 13:47 ` Luca Ceresoli
2020-02-26 16:30 ` Rob Herring
2020-02-20 17:24 ` [RFC PATCH 4/7] i2c: of: remove superfluous parameter from exported function Wolfram Sang
2020-02-21 9:50 ` Geert Uytterhoeven
2020-02-24 8:12 ` Luca Ceresoli
2020-02-20 17:24 ` [RFC PATCH 5/7] i2c: of: error message unification Wolfram Sang
2020-02-21 9:54 ` Geert Uytterhoeven
2020-02-20 17:24 ` [RFC PATCH 6/7] i2c: of: mark a whole array of regs as reserved Wolfram Sang
2020-02-21 10:09 ` Geert Uytterhoeven
2020-03-12 11:21 ` Wolfram Sang
2020-03-18 14:33 ` Wolfram Sang
2020-02-28 12:11 ` Luca Ceresoli
2020-02-20 17:24 ` Wolfram Sang [this message]
2020-02-21 10:13 ` [RFC PATCH 7/7] i2c: core: hand over reserved devices when requesting ancillary addresses Geert Uytterhoeven
2020-02-28 12:11 ` Luca Ceresoli
2020-03-12 11:30 ` Wolfram Sang
2020-03-12 11:21 ` Wolfram Sang
2020-03-13 12:42 ` Wolfram Sang
2020-02-21 10:15 ` [RFC PATCH 0/7] i2c: of: reserve unknown and " Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200220172403.26062-8-wsa+renesas@sang-engineering.com \
--to=wsa+renesas@sang-engineering.com \
--cc=devicetree@vger.kernel.org \
--cc=jacopo@jmondi.org \
--cc=kieran@bingham.xyz \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=luca@lucaceresoli.net \
--cc=niklas.soderlund@ragnatech.se \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).