From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Rajeev Huralikoppi <rajeev.huralikoppi@silvaco.com>,
Nicolas Pitre <nico@fluxnic.net>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
linux-i3c@lists.infradead.org,
Conor Culhane <conor.culhane@silvaco.com>
Subject: Re: [PATCH v4 1/6] dt-bindings: i3c: Convert controller description to yaml
Date: Mon, 18 Jan 2021 18:21:17 +0100 [thread overview]
Message-ID: <20210118182117.311feb44@xps13> (raw)
In-Reply-To: <20210115170312.GA1434283@robh.at.kernel.org>
Hi Rob,
Just another question.
> > +patternProperties:
> > + "^.*@[0-9a-f]+$":
>
> You can drop '^.*':
>
> "@[0-9a-f]+$"
Here you advise to drop the beginning + wildcard of the regex matching
for I2C children, which indeed makes sense to me.
[...]
> > + "^.*@[0-9a-f]+,[0-9a-f]+$":
Later in the file, we use another regex to match I3C devices. But here
if I drop ^.* from the regex, I get the following error:
schemas/i3c/i3c.yaml: ignoring, error in schema: patternProperties: @[0-9a-f]+,[0-9a-f]+$
<path>/i3c.yaml: patternProperties:@[0-9a-f]+,[0-9a-f]+$: 'oneOf' conditional failed, one must be fixed:
Additional properties are not allowed ('properties', 'required' were unexpected)
<path>/i3c.yaml: patternProperties:@[0-9a-f]+,[0-9a-f]+$: 'oneOf' conditional failed, one must be fixed:
'enum' is a required property
'const' is a required property
Additional properties are not allowed ('properties', 'required', 'type' were unexpected)
<path>/i3c.yaml: patternProperties:@[0-9a-f]+,[0-9a-f]+$: 'oneOf' conditional failed, one must be fixed:
'$ref' is a required property
'allOf' is a required property
'boolean' was expected
I can keep this extra "^.*" but I would like to understand the error
better because this does not look right.
Thanks,
Miquèl
--
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
next prev parent reply other threads:[~2021-01-18 17:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-14 17:55 [PATCH v4 0/6] Silvaco I3C master driver Miquel Raynal
2021-01-14 17:55 ` [PATCH v4 1/6] dt-bindings: i3c: Convert controller description to yaml Miquel Raynal
2021-01-15 17:03 ` Rob Herring
2021-01-18 15:25 ` Miquel Raynal
2021-01-18 17:21 ` Miquel Raynal [this message]
2021-01-14 17:55 ` [PATCH v4 2/6] dt-bindings: i3c: mipi-hci: Include the bus binding Miquel Raynal
2021-01-14 22:54 ` Rob Herring
2021-01-14 17:55 ` [PATCH v4 3/6] dt-bindings: Add vendor prefix for Silvaco Miquel Raynal
2021-01-14 17:55 ` [PATCH v4 4/6] dt-bindings: i3c: Describe Silvaco master binding Miquel Raynal
2021-01-15 17:08 ` Rob Herring
2021-01-14 17:55 ` [PATCH v4 5/6] i3c: master: svc: Add Silvaco I3C master driver Miquel Raynal
2021-01-14 17:55 ` [PATCH v4 6/6] MAINTAINERS: Add Silvaco I3C master Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210118182117.311feb44@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=alexandre.belloni@bootlin.com \
--cc=conor.culhane@silvaco.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-i3c@lists.infradead.org \
--cc=nico@fluxnic.net \
--cc=rajeev.huralikoppi@silvaco.com \
--cc=robh@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).