From: vitor <vitor.soares@synopsys.com>
To: Boris Brezillon <boris.brezillon@collabora.com>,
vitor <vitor.soares@synopsys.com>
Cc: Przemyslaw Gaj <pgaj@cadence.com>,
linux-i3c@lists.infradead.org, rafalc@cadence.com,
bbrezillon@kernel.org
Subject: Re: [PATCH v2 1/3] i3c: Drop support for I2C 10 bit addresing
Date: Wed, 27 Feb 2019 12:52:42 +0000 [thread overview]
Message-ID: <6bed8050-74ea-5dcf-e750-62fa6c1580ef@synopsys.com> (raw)
In-Reply-To: <20190227131004.66ed9fa1@collabora.com>
Hi,
On 27/02/19 12:10, Boris Brezillon wrote:
> Hi Vitor,
>
> On Wed, 27 Feb 2019 12:05:30 +0000
> vitor <vitor.soares@synopsys.com> wrote:
>
>> On 26/02/19 14:28, Przemyslaw Gaj wrote:
>>> This patch dropps support for I2C devices with 10 bit addressing. When I2C
>>> device with 10 bit address is defined in DT, I3C master registration fails.
>>>
>>> Signed-off-by: Przemyslaw Gaj <pgaj@cadence.com>
>>>
>>> ---
>>>
>>> Main changes between v1 and v2 are:
>>> - Add error message when registering I2C device with 10 bit address.
>>>
>>> ---
>>> drivers/i3c/master.c | 9 +++++++++
>>> 1 file changed, 9 insertions(+)
>>>
>>> diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c
>>> index 2dc628d..8c1e365 100644
>>> --- a/drivers/i3c/master.c
>>> +++ b/drivers/i3c/master.c
>>> @@ -1962,6 +1962,15 @@ of_i3c_master_add_i2c_boardinfo(struct i3c_master_controller *master,
>>> if (ret)
>>> return ret;
>>>
>>> + /* The I3C Specification does not clearly say I2C devices with 10-bit
>>> + * address are supported. These devices can't be passed properly through
>>> + * DEFSLVS command.
>>> + */
>> IMO we just need to say 10-bit address not used or not supported in i3c.
> I'd like to keep a clear comment on why it cannot supported right now
> even though the spec is unclear about that. If the spec is updated to
> state that I2C devs using extended addresses are forbidden, then we'll
> update this comment accordingly.
I'm not sure if the terms aren't the same, but let's keep the comment.
>
>>> + if (boardinfo->base.flags & I2C_CLIENT_TEN) {
>>> + dev_err(&master->dev, "I2C device with 10 bit address not supported.");
>>> + return -ENOTSUPP;
>>> + }
>>> +
>>> /* LVR is encoded in reg[2]. */
>>> boardinfo->lvr = reg[2];
>>>
>> Also need to change:
>>
>> #define I2C_MAX_ADDR GENMASK(9, 0)
>> to
>> #define I2C_MAX_ADDR GENMASK(6, 0)
>> in master.h file
> Yep, you can reduce the address space.
>
>> Not sure about:
>> unsigned long addrslots[((I2C_MAX_ADDR + 1) * 2) / BITS_PER_LONG];
>> @Boris can you check this part?
> This part is still valid, no need to update it as you already updated
> I2C_MAX_ADDR.
>
> Thanks for the review.
>
> Boris
Also we can make i2c_algorithm.functionality = I2C_FUNC_SMBUS_EMUL | I2C_FUNC_I2C, and in this way we won't need ->i2c_func() and avoid the I2C_FUNC_10BIT_ADDR flag on host controller side.
Best regards,
Vitor Soares
_______________________________________________
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
next prev parent reply other threads:[~2019-02-27 12:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-26 14:28 [PATCH v2 0/3] Drop support for I2C 10 bit devices from I3C subsystem Przemyslaw Gaj
2019-02-26 14:28 ` [PATCH v2 1/3] i3c: Drop support for I2C 10 bit addresing Przemyslaw Gaj
2019-02-27 12:05 ` vitor
2019-02-27 12:10 ` Boris Brezillon
2019-02-27 12:52 ` vitor [this message]
2019-02-27 13:09 ` Boris Brezillon
2019-02-26 14:28 ` [PATCH v2 2/3] i3c: master: cdns: Drop support for I2C 10 bit addresing in Cadence I3C master Przemyslaw Gaj
2019-02-26 14:28 ` [PATCH v2 3/3] dt-bindings: i3c: Document dropped support for I2C 10 bit devices Przemyslaw Gaj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6bed8050-74ea-5dcf-e750-62fa6c1580ef@synopsys.com \
--to=vitor.soares@synopsys.com \
--cc=bbrezillon@kernel.org \
--cc=boris.brezillon@collabora.com \
--cc=linux-i3c@lists.infradead.org \
--cc=pgaj@cadence.com \
--cc=rafalc@cadence.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).