RE: [PATCH] i3c: make sure the PID is set before registering the device

[Vitor Soares <Vitor.Soares@synopsys.com>]

Hi Boris,

From: Boris Brezillon <boris.brezillon@collabora.com>
Date: Mon, Dec 09, 2019 at 09:47:11

> On Sun, 8 Dec 2019 15:18:34 +0100
> Przemysław Gaj <pgaj@cadence.com> wrote:
> 
> > From: Przemyslaw Gaj <pgaj@cadence.com>
> > 
> > Provisioned ID (PID) is the value with which device drivers are
> > matched. I check the value before registering the device.
> > 
> 
> Can this situation (having a device with a DA but without a valid PID)
> happen right now or is this something you need to support secondary
> masters who receive device DA (through DEFSVLS) without being able to
> query extra information until they own the bus?

This is the use case where a device fails the 
i3c_master_pre_assign_dyn_addr() and I already mention it on [1].
I still think the best way is to detach/free the devices that fails 
during i3c_master_pre_assign_dyn_addr().

> 
> > Signed-off-by: Przemyslaw Gaj <pgaj@cadence.com>
> > ---
> >  drivers/i3c/master.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c
> > index 043691656245..07ea8b0b7736 100644
> > --- a/drivers/i3c/master.c
> > +++ b/drivers/i3c/master.c
> > @@ -1449,7 +1449,8 @@ i3c_master_register_new_i3c_devs(struct i3c_master_controller *master)
> >  		return;
> >  
> >  	i3c_bus_for_each_i3cdev(&master->bus, desc) {
> > -		if (desc->dev || !desc->info.dyn_addr || desc == master->this)
> > +		if (desc->dev || !desc->info.dyn_addr ||
> > +		    desc == master->this || !desc->info.pid)
> >  			continue;
> >  
> >  		desc->dev = kzalloc(sizeof(*desc->dev), GFP_KERNEL);

Best regards,
Vitor Soares

[1] https://patchwork.kernel.org/patch/11132601/
_______________________________________________
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c