From: Vitor Soares <Vitor.Soares@synopsys.com>
To: "Przemysław Gaj" <pgaj@cadence.com>,
"bbrezillon@kernel.org" <bbrezillon@kernel.org>,
"Joao Pinto" <Joao.Pinto@synopsys.com>
Cc: "linux-i3c@lists.infradead.org" <linux-i3c@lists.infradead.org>,
"rafalc@cadence.com" <rafalc@cadence.com>
Subject: RE: [PATCH v4 6/6] i3c: master: dw: reattach device on first available location of address table
Date: Tue, 10 Dec 2019 14:40:49 +0000 [thread overview]
Message-ID: <CH2PR12MB42165699E80C5063BE111BB7AE5B0@CH2PR12MB4216.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20191210101502.8401-7-pgaj@cadence.com>
++João Pinto
Hi Przemysław,
Sorry for this, but please drop this patch from this series. Boris as
Maintainer could already merge it when gives rb tag.
From: Przemysław Gaj <pgaj@cadence.com>
Date: Tue, Dec 10, 2019 at 10:15:02
> From: Vitor Soares <vitor.soares@synopsys.com>
>
> For today the reattach function only update the device address on the
> controller.
>
> Update the location to the first available too, will optimize the
> enumeration process avoiding additional checks to keep the available
> positions on address table consecutive.
>
> Signed-off-by: Vitor Soares <vitor.soares@synopsys.com>
> Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
> Signed-off-by: Przemyslaw Gaj <pgaj@cadence.com>
> ---
> Change in v3:
> - None
>
> Change in v2:
> - Add Boris rb-tag
> ---
> drivers/i3c/master/dw-i3c-master.c | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw-i3c-master.c
> index b0ff0e12d84c..c6caba39a34b 100644
> --- a/drivers/i3c/master/dw-i3c-master.c
> +++ b/drivers/i3c/master/dw-i3c-master.c
> @@ -899,6 +899,22 @@ static int dw_i3c_master_reattach_i3c_dev(struct i3c_dev_desc *dev,
> struct dw_i3c_i2c_dev_data *data = i3c_dev_get_master_data(dev);
> struct i3c_master_controller *m = i3c_dev_get_master(dev);
> struct dw_i3c_master *master = to_dw_i3c_master(m);
> + int pos;
> +
> + pos = dw_i3c_master_get_free_pos(master);
> +
> + if (data->index > pos && pos > 0) {
> + writel(0,
> + master->regs +
> + DEV_ADDR_TABLE_LOC(master->datstartaddr, data->index));
> +
> + master->addrs[data->index] = 0;
> + master->free_pos |= BIT(data->index);
> +
> + data->index = pos;
> + master->addrs[pos] = dev->info.dyn_addr;
> + master->free_pos &= ~BIT(pos);
> + }
>
> writel(DEV_ADDR_TABLE_DYNAMIC_ADDR(dev->info.dyn_addr),
> master->regs +
> --
> 2.14.0
Best regards,
Vitor Soares
_______________________________________________
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
next prev parent reply other threads:[~2019-12-10 14:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-10 10:14 [PATCH v4 0/6] I3C device addresing adjustments Przemysław Gaj
2019-12-10 10:14 ` [PATCH v4 1/6] i3c: master: make sure ->boardinfo is initialized in add_i3c_dev_locked() Przemysław Gaj
2019-12-10 10:14 ` [PATCH v4 2/6] i3c: master: pre-reserve boardinfo->init_dyn_addr when available Przemysław Gaj
2019-12-10 13:29 ` Boris Brezillon
2019-12-10 15:24 ` Vitor Soares
2019-12-11 8:51 ` Przemysław Gaj
2019-12-10 10:14 ` [PATCH v4 3/6] i3c: master: make sure the PID is set before registering the device Przemysław Gaj
2019-12-10 10:15 ` [PATCH v4 4/6] dt-bindings: i3c: Make 'assigned-address' valid if static address == 0 Przemysław Gaj
2019-12-10 10:15 ` [PATCH v4 5/6] dt-bindings: i3c: add a note for no guarantee of 'assigned-address' use Przemysław Gaj
2019-12-10 10:15 ` [PATCH v4 6/6] i3c: master: dw: reattach device on first available location of address table Przemysław Gaj
2019-12-10 14:40 ` Vitor Soares [this message]
2019-12-10 14:43 ` Przemysław Gaj
2019-12-10 14:52 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CH2PR12MB42165699E80C5063BE111BB7AE5B0@CH2PR12MB4216.namprd12.prod.outlook.com \
--to=vitor.soares@synopsys.com \
--cc=Joao.Pinto@synopsys.com \
--cc=bbrezillon@kernel.org \
--cc=linux-i3c@lists.infradead.org \
--cc=pgaj@cadence.com \
--cc=rafalc@cadence.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).