From: Sergey Shtylyov <s.shtylyov@omp.ru>
To: Fabio Estevam <festevam@gmail.com>
Cc: Sergey Shtylyov <s.shtylyov@omprussia.ru>,
Jens Axboe <axboe@kernel.dk>, <linux-ide@vger.kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
NXP Linux Team <linux-imx@nxp.com>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 4/4] pata_imx: deny IRQ0
Date: Mon, 20 Sep 2021 19:41:23 +0300 [thread overview]
Message-ID: <06b8794c-102e-6c85-5f73-ebdc2d30b246@omp.ru> (raw)
In-Reply-To: <CAOMZO5A3NiOOg8Zv1+mXh_VixuQ3=KLFPG-7CphQt-S997XV5A@mail.gmail.com>
On 9/20/21 3:45 PM, Fabio Estevam wrote:
>>> IMHO the current code is correct as-is.
>>
>> Not quite... I don't want to leave a bad example for the future driver authors. What should
>> I change in the patch description for the patch to become acceptable for you?
>
> Please see how the PCI subsystem has converted the handling of
> platform_get_irq():
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v5.15-rc2&id=0584bff09629666eea97c7ac428e55b00df211f5
Thanks for the link -- that's what I've been doing for the drivers outside PCI in the
past few months. :-)
> Why does drivers/ata/ need to handle platform_get_irq() differently?
Because ata_host_activate() treats irq0 as polling indicater and complains about
the 'handler' being non-NULL.
> I still don't see the need for changing drivers/ata/pata_imx.c in this aspect.
And now?
MBR, Sergei
next prev parent reply other threads:[~2021-09-20 16:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-21 18:50 [PATCH 0/4] Explicitly deny IRQ0 in the libata drivers Sergey Shtylyov
2021-03-21 18:54 ` [PATCH 1/4] pata_bk3710: deny IRQ0 Sergey Shtylyov
2021-03-21 18:55 ` [PATCH 2/4] pata_ep93xx: " Sergey Shtylyov
2021-03-21 18:57 ` [PATCH 3/4] pata_ftide010: " Sergey Shtylyov
2021-03-21 18:59 ` [PATCH 4/4] pata_imx: " Sergey Shtylyov
2021-03-21 19:06 ` Fabio Estevam
2021-09-18 20:49 ` Sergey Shtylyov
2021-09-20 12:45 ` Fabio Estevam
2021-09-20 12:52 ` Fabio Estevam
2021-09-20 16:42 ` Sergey Shtylyov
2021-09-20 16:41 ` Sergey Shtylyov [this message]
2021-05-10 20:48 ` [PATCH 0/4] Explicitly deny IRQ0 in the libata drivers Sergey Shtylyov
2021-09-04 18:57 ` Sergey Shtylyov
2021-09-04 21:25 ` Jens Axboe
2021-09-05 9:47 ` Sergey Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06b8794c-102e-6c85-5f73-ebdc2d30b246@omp.ru \
--to=s.shtylyov@omp.ru \
--cc=axboe@kernel.dk \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=s.hauer@pengutronix.de \
--cc=s.shtylyov@omprussia.ru \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).