From: Hannes Reinecke <hare@suse.de>
To: Damien Le Moal <Damien.LeMoal@wdc.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
Jens Axboe <axboe@kernel.dk>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>
Subject: Re: [PATCH v3 1/4] block: Add concurrent positioning ranges support
Date: Mon, 26 Jul 2021 10:47:38 +0200 [thread overview]
Message-ID: <0ec2ea13-208f-1a5e-7b11-37317b5e56b8@suse.de> (raw)
In-Reply-To: <DM6PR04MB7081141B64D9501BDA876433E7E89@DM6PR04MB7081.namprd04.prod.outlook.com>
On 7/26/21 10:30 AM, Damien Le Moal wrote:
> On 2021/07/26 16:34, Hannes Reinecke wrote:
[ .. ]
>> In principle it looks good, but what would be the appropriate action
>> when invalid ranges are being detected during revalidation?
>> The current code will leave the original ones intact, but I guess that's
>> questionable as the current settings are most likely invalid.
>
> Nope. In that case, the old ranges are removed. In blk_queue_set_cranges(),
> there is:
>
> + if (!blk_check_ranges(disk, cr)) {
> + kfree(cr);
> + cr = NULL;
> + goto reg;
> + }
>
> So for incorrect ranges, we will register "NULL", so no ranges. The old ranges
> are gone.
>
Right. So that's the first concern addressed.
>> I would vote for de-register the old ones and implement an error state
>> (using an error pointer?); that would signal that there _are_ ranges,
>> but we couldn't parse them properly.
>> Hmm?
>
> With the current code, the information "there are ranges" will be completely
> gone if the ranges are bad... dmesg will have a message about it, but that's it.
>
So there will be no additional information in sysfs in case of incorrect
ranges?
Hmm. Not sure if I like that, but then it might be the best option after
all. So you can add my:
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@suse.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer
next prev parent reply other threads:[~2021-07-26 8:47 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-26 1:38 [PATCH v3 0/4] Initial support for multi-actuator HDDs Damien Le Moal
2021-07-26 1:38 ` [PATCH v3 1/4] block: Add concurrent positioning ranges support Damien Le Moal
2021-07-26 7:33 ` Hannes Reinecke
2021-07-26 8:30 ` Damien Le Moal
2021-07-26 8:47 ` Hannes Reinecke [this message]
2021-07-26 11:33 ` Damien Le Moal
2021-07-27 14:07 ` Paolo Valente
2021-07-27 23:44 ` Damien Le Moal
2021-08-10 8:23 ` Christoph Hellwig
2021-08-10 11:03 ` Damien Le Moal
2021-08-10 16:02 ` hch
2021-08-10 23:46 ` Damien Le Moal
2021-07-26 1:38 ` [PATCH v3 2/4] scsi: sd: add " Damien Le Moal
2021-08-10 8:24 ` Christoph Hellwig
2021-07-26 1:38 ` [PATCH v3 3/4] libata: support concurrent positioning ranges log Damien Le Moal
2021-07-26 7:34 ` Hannes Reinecke
2021-08-10 8:26 ` Christoph Hellwig
2021-07-26 1:38 ` [PATCH v3 4/4] doc: document sysfs queue/cranges attributes Damien Le Moal
2021-07-26 7:35 ` Hannes Reinecke
2021-08-10 8:27 ` Christoph Hellwig
2021-08-10 11:04 ` Damien Le Moal
2021-07-28 22:59 ` [PATCH v3 0/4] Initial support for multi-actuator HDDs Damien Le Moal
2021-08-06 2:12 ` Damien Le Moal
2021-08-06 3:41 ` Martin K. Petersen
2021-08-06 4:05 ` Damien Le Moal
2021-08-06 8:35 ` Hannes Reinecke
2021-08-06 8:52 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ec2ea13-208f-1a5e-7b11-37317b5e56b8@suse.de \
--to=hare@suse.de \
--cc=Damien.LeMoal@wdc.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).