From: sven.auhagen@voleatech.de
To: axboe@kernel.dk, hdegoede@redhat.com, robh+dt@kernel.org,
tglx@linutronix.de, maz@kernel.org, gregory.clement@bootlin.com
Cc: linux-ide@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, jason@lakedaemon.net, andrew@lunn.ch,
rjw@rjwysocki.net, viresh.kumar@linaro.org,
antoine.tenart@bootlin.com, maxime.chevallier@bootlin.com,
thomas.petazzoni@bootlin.com, miquel.raynal@bootlin.com
Subject: [PATCH v3 3/9] ata: libahci_platform: Do not try to get an IRQ when AHCI_HFLAG_MULTI_MSI is set
Date: Mon, 9 Nov 2020 18:39:42 +0100 [thread overview]
Message-ID: <20201109173948.96663-4-sven.auhagen@voleatech.de> (raw)
In-Reply-To: <20201109173948.96663-1-sven.auhagen@voleatech.de>
From: Sven Auhagen <sven.auhagen@voleatech.de>
When the ahci-host AHCI_HFLAG_MULTI_MSI flag is set then the driver must
provide a get_irq_vector callback and take care of getting the IRQs itself.
So in this case ahci_platform_init_host() should not try to get an
IRQ itself.
Suggested-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Sven Auhagen <sven.auhagen@voleatech.de>
---
drivers/ata/libahci_platform.c | 16 +++++++++-------
1 file changed, 9 insertions(+), 7 deletions(-)
diff --git a/drivers/ata/libahci_platform.c b/drivers/ata/libahci_platform.c
index de638dafce21..f6f2a111d226 100644
--- a/drivers/ata/libahci_platform.c
+++ b/drivers/ata/libahci_platform.c
@@ -581,14 +581,16 @@ int ahci_platform_init_host(struct platform_device *pdev,
struct ata_host *host;
int i, irq, n_ports, rc;
- irq = platform_get_irq(pdev, 0);
- if (irq <= 0) {
- if (irq != -EPROBE_DEFER)
- dev_err(dev, "no irq\n");
- return irq;
- }
+ if (!(hpriv->flags & AHCI_HFLAG_MULTI_MSI)) {
+ irq = platform_get_irq(pdev, 0);
+ if (irq <= 0) {
+ if (irq != -EPROBE_DEFER)
+ dev_err(dev, "no irq\n");
+ return irq;
+ }
- hpriv->irq = irq;
+ hpriv->irq = irq;
+ }
/* prepare host */
pi.private_data = (void *)(unsigned long)hpriv->flags;
--
2.20.1
next prev parent reply other threads:[~2020-11-09 17:40 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-09 17:39 [PATCH v3 0/9] Armada8k enable per-port SATA interrupts and drop a hack in the IRQ subsystem sven.auhagen
2020-11-09 17:39 ` [PATCH v3 1/9] ata: ahci: mvebu: Rename a platform data flag sven.auhagen
2020-11-09 17:39 ` [PATCH v3 2/9] ata: ahci: mvebu: Support A8k compatible sven.auhagen
2020-11-09 17:39 ` sven.auhagen [this message]
2020-11-09 17:39 ` [PATCH v3 4/9] ata: ahci: add ack callback to multi irq handler sven.auhagen
2020-11-09 17:39 ` [PATCH v3 5/9] ata: ahci: mvebu: Add support for A8k legacy DT bindings sven.auhagen
2020-11-09 17:39 ` [PATCH v3 6/9] irqchip/irq-mvebu-icu: Remove the double SATA ports interrupt hack sven.auhagen
2020-11-09 17:39 ` [PATCH v3 7/9] dt-bindings: ata: Update ahci bindings with possible per-port interrupts sven.auhagen
2020-11-09 17:39 ` [PATCH v3 8/9] dt-bindings: ata: Update ahci_mvebu bindings sven.auhagen
2020-11-09 17:39 ` [PATCH v3 9/9] arm64: dts: marvell: armada-cp110: Switch to per-port SATA interrupts sven.auhagen
2020-11-29 11:25 ` Gregory CLEMENT
2021-02-27 10:57 ` [PATCH v3 0/9] Armada8k enable per-port SATA interrupts and drop a hack in the IRQ subsystem Sven Auhagen
2021-03-19 2:34 ` Marcin Wojtas
2021-03-19 7:35 ` Gregory CLEMENT
2021-03-19 8:08 ` Marcin Wojtas
2021-03-19 9:33 ` Marc Zyngier
2021-03-19 9:48 ` Marcin Wojtas
2021-03-19 20:40 ` Mark Kettenis
2021-03-19 20:53 ` Andrew Lunn
2021-03-19 22:13 ` Marcin Wojtas
2021-03-19 22:28 ` Andrew Lunn
2021-03-19 7:26 ` Gregory CLEMENT
2021-03-19 8:16 ` Sven Auhagen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201109173948.96663-4-sven.auhagen@voleatech.de \
--to=sven.auhagen@voleatech.de \
--cc=andrew@lunn.ch \
--cc=antoine.tenart@bootlin.com \
--cc=axboe@kernel.dk \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=hdegoede@redhat.com \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=maz@kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
--cc=thomas.petazzoni@bootlin.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).