linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: lee.jones@linaro.org
Cc: linux-kernel@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
	linux-ide@vger.kernel.org
Subject: [PATCH 14/15] ata: libata-acpi: Fix function name and provide description for 'prev_gtf'
Date: Thu, 18 Mar 2021 08:51:49 +0000	[thread overview]
Message-ID: <20210318085150.3131936-15-lee.jones@linaro.org> (raw)
In-Reply-To: <20210318085150.3131936-1-lee.jones@linaro.org>

Fixes the following W=1 kernel build warning(s):

 drivers/ata/libata-acpi.c:493: warning: expecting prototype for ata_acpi_gtm_xfermode(). Prototype was for ata_acpi_gtm_xfermask() instead
 drivers/ata/libata-acpi.c:648: warning: Function parameter or member 'prev_gtf' not described in 'ata_acpi_run_tf'

Cc: Jens Axboe <axboe@kernel.dk>
Cc: linux-ide@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/ata/libata-acpi.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/ata/libata-acpi.c b/drivers/ata/libata-acpi.c
index 224e3486e9a5d..7a7d6642edcc5 100644
--- a/drivers/ata/libata-acpi.c
+++ b/drivers/ata/libata-acpi.c
@@ -476,7 +476,7 @@ static int ata_dev_get_GTF(struct ata_device *dev, struct ata_acpi_gtf **gtf)
 }
 
 /**
- * ata_acpi_gtm_xfermode - determine xfermode from GTM parameter
+ * ata_acpi_gtm_xfermask - determine xfermode from GTM parameter
  * @dev: target device
  * @gtm: GTM parameter to use
  *
@@ -624,6 +624,7 @@ static int ata_acpi_filter_tf(struct ata_device *dev,
  * ata_acpi_run_tf - send taskfile registers to host controller
  * @dev: target ATA device
  * @gtf: raw ATA taskfile register set (0x1f1 - 0x1f7)
+ * @prev_gtf: previous command
  *
  * Outputs ATA taskfile to standard ATA host controller.
  * Writes the control, feature, nsect, lbal, lbam, and lbah registers.
-- 
2.27.0


  parent reply	other threads:[~2021-03-18  8:52 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-18  8:51 [PATCH 00/15] [Set 2] Rid W=1 warnings from ATA Lee Jones
2021-03-18  8:51 ` [PATCH 01/15] ata: pata_pdc202xx_old: Fix some incorrectly named functions Lee Jones
2021-03-18  8:51 ` [PATCH 02/15] ata: pata_sil680: Add some missing function parameter docs Lee Jones
2021-03-18  8:51 ` [PATCH 03/15] ata: pata_sis: Remove superfluous param description and supply another Lee Jones
2021-03-18  8:51 ` [PATCH 04/15] ata: pata_triflex: Repair some misnamed functions and fix some param descriptions Lee Jones
2021-03-18  8:51 ` [PATCH 05/15] ata: pata_it821x: Fix possible doc-rotted function names Lee Jones
2021-03-18  8:51 ` [PATCH 06/15] ata: pata_via: Fix a kernel-doc formatting issue Lee Jones
2021-03-18  8:51 ` [PATCH 07/15] ata: pata_piccolo: 'ata_tosh_init()' is misnamed in its header Lee Jones
2021-03-18  8:51 ` [PATCH 08/15] ata: pata_sl82c105: Fix potential doc-rot Lee Jones
2021-03-18  8:51 ` [PATCH 09/15] ata: pata_opti: Fix spelling issue of 'val' in 'opti_write_reg()' Lee Jones
2021-03-18  8:51 ` [PATCH 10/15] ata: ata_generic: Fix misspelling of 'ata_generic_init_one()' Lee Jones
2021-03-18  8:51 ` [PATCH 11/15] ata: pata_legacy: Repair a couple kernel-doc problems Lee Jones
2021-03-18  8:51 ` [PATCH 12/15] ata: pata_cs5530: Fix misspelling of 'cs5530_init_one()'s 'pdev' param Lee Jones
2021-03-18  8:51 ` [PATCH 13/15] ata: sata_mv: Fix misnaming of 'mv_bmdma_stop()' Lee Jones
2021-03-18  8:51 ` Lee Jones [this message]
2021-03-18  8:51 ` [PATCH 15/15] ata: pata_acpi: Fix some incorrect function param descriptions Lee Jones
2021-03-30 13:20 ` [PATCH 00/15] [Set 2] Rid W=1 warnings from ATA Lee Jones
2021-03-31  2:21 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210318085150.3131936-15-lee.jones@linaro.org \
    --to=lee.jones@linaro.org \
    --cc=axboe@kernel.dk \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).