From: Rob Herring <robh@kernel.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-ide@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Imre Kaloz <kaloz@openwrt.org>,
Krzysztof Halasa <khalasa@piap.pl>,
devicetree@vger.kernel.org
Subject: Re: [PATCH 4/5] pata: ixp4xx: Add DT bindings
Date: Wed, 28 Jul 2021 10:14:41 -0600 [thread overview]
Message-ID: <20210728161441.GA1163345@robh.at.kernel.org> (raw)
In-Reply-To: <20210728090242.2758812-5-linus.walleij@linaro.org>
On Wed, Jul 28, 2021 at 11:02:41AM +0200, Linus Walleij wrote:
> This adds device tree bindings for the Intel IXP4xx compact flash card
> interface.
>
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> .../ata/intel,ixp4xx-compact-flash.yaml | 62 +++++++++++++++++++
> 1 file changed, 62 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/ata/intel,ixp4xx-compact-flash.yaml
>
> diff --git a/Documentation/devicetree/bindings/ata/intel,ixp4xx-compact-flash.yaml b/Documentation/devicetree/bindings/ata/intel,ixp4xx-compact-flash.yaml
> new file mode 100644
> index 000000000000..b254be858de6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/ata/intel,ixp4xx-compact-flash.yaml
> @@ -0,0 +1,62 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/ata/intel,ixp4xx-compact-flash.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Intel IXP4xx CompactFlash Card Controller
> +
> +maintainers:
> + - Linus Walleij <linus.walleij@linaro.org>
> +
> +description: |
> + The IXP4xx network processors have a CompactFlash interface that presents
> + a CompactFlash card to the system as a true IDE (parallell ATA) device. The
typo. (you can setup checkpatch.pl to do spell checking)
> + device is always connected to the expansion bus of the IXP4xx SoCs using one
> + or two chip select areas and address translating logic on the board. The
> + node must be placed inside a chip select node on the IXP4xx expansion bus.
> +
> +properties:
> + compatible:
> + const: intel,ixp4xx-compact-flash
> +
> + reg:
> + minItems: 2
> + maxItems: 2
What is each entry?
> +
> + interrupts:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> +
> +allOf:
> + - $ref: pata-common.yaml#
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> +
> + bus@c4000000 {
> + compatible = "intel,ixp43x-expansion-bus-controller", "syscon";
> + reg = <0xc4000000 0x1000>;
> + native-endian;
> + #address-cells = <2>;
> + #size-cells = <1>;
> + ranges = <0 0x0 0x50000000 0x01000000>, <1 0x0 0x51000000 0x01000000>;
> + dma-ranges = <0 0x0 0x50000000 0x01000000>, <1 0x0 0x51000000 0x01000000>;
> + ide@1,0 {
> + compatible = "intel,ixp4xx-compact-flash";
> + intel,ixp4xx-eb-t1 = <3>;
> + intel,ixp4xx-eb-t2 = <3>;
Can you omit these? Otherwise, this will start failing soon as
unevaluatedProperties is implemented (I have a test branch). Or you need
to handle child node properties as discussed.
> + reg = <1 0x00000000 0x1000>, <1 0x00040000 0x1000>;
> + interrupt-parent = <&gpio0>;
> + interrupts = <12 IRQ_TYPE_EDGE_RISING>;
> + };
> + };
> +
> +...
> --
> 2.31.1
>
>
next prev parent reply other threads:[~2021-07-28 16:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-28 9:02 [PATCH 0/5] Update and rewrite IXP4xx PATA driver Linus Walleij
2021-07-28 9:02 ` [PATCH 1/5] pata: ixp4xx: Use local dev variable Linus Walleij
2021-07-28 9:02 ` [PATCH 2/5] pata: ixp4xx: Use IS_ENABLED() to determine endianness Linus Walleij
2021-07-28 9:02 ` [PATCH 3/5] pata: ixp4xx: Refer to cmd and ctl rather than csN Linus Walleij
2021-07-28 9:02 ` [PATCH 4/5] pata: ixp4xx: Add DT bindings Linus Walleij
2021-07-28 16:14 ` Rob Herring [this message]
2021-07-28 9:02 ` [PATCH 5/5] pata: ixp4xx: Rewrite to use device tree Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210728161441.GA1163345@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=axboe@kernel.dk \
--cc=devicetree@vger.kernel.org \
--cc=kaloz@openwrt.org \
--cc=khalasa@piap.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).