From: "Reimar Döffinger" <Reimar.Doeffinger@gmx.de>
To: Damien Le Moal <Damien.LeMoal@wdc.com>,
linux-ide@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
hch@infradead.org, Paul Menzel <pmenzel@molgen.mpg.de>
Subject: [PATCH 4/6] pata_amd: fix checking of DMA state
Date: Sun, 3 Oct 2021 15:28:49 +0200 [thread overview]
Message-ID: <20211003132851.12574-5-Reimar.Doeffinger@gmx.de> (raw)
In-Reply-To: <20211003132851.12574-1-Reimar.Doeffinger@gmx.de>
Checking if DMA is enabled should be done via the
ata_dma_enabled helper function, since the init state
0xff indicates disabled.
Change based on code review, not tested due to lack of hardware.
Signed-off-by: Reimar Döffinger <Reimar.Doeffinger@gmx.de>
---
drivers/ata/pata_amd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/pata_amd.c b/drivers/ata/pata_amd.c
index c8acba162d02..154748cfcc79 100644
--- a/drivers/ata/pata_amd.c
+++ b/drivers/ata/pata_amd.c
@@ -66,7 +66,7 @@ static void timing_setup(struct ata_port *ap, struct ata_device *adev, int offse
if (peer) {
/* This may be over conservative */
- if (peer->dma_mode) {
+ if (ata_dma_enabled(peer)) {
ata_timing_compute(peer, peer->dma_mode, &apeer, T, UT);
ata_timing_merge(&apeer, &at, &at, ATA_TIMING_8BIT);
}
--
2.33.0
next prev parent reply other threads:[~2021-10-03 11:29 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-14 13:47 [PATCH] libata: add kernel parameter to force ATA_HORKAGE_NO_DMA_LOG Reimar Döffinger
2021-08-15 8:18 ` Christoph Hellwig
2021-08-15 16:27 ` [PATCH] libata: Disable ATA_CMD_READ_LOG_DMA_EXT in problematic cases Reimar Döffinger
2021-08-16 0:10 ` Damien Le Moal
2021-08-16 17:15 ` Reimar Döffinger
2021-08-17 19:06 ` Reimar Döffinger
2021-08-18 22:49 ` Damien Le Moal
2021-08-16 17:26 ` Reimar Döffinger
2021-08-17 7:45 ` Damien Le Moal
2021-08-17 18:01 ` Reimar Döffinger
2021-08-17 19:03 ` [PATCH] libata: fix setting and checking of DMA state Reimar Döffinger
2021-08-18 23:30 ` Damien Le Moal
2021-08-19 8:13 ` [PATCH] libata: fix " Reimar Döffinger
2021-08-19 12:56 ` Reimar Döffinger
2021-09-27 8:56 ` Paul Menzel
2021-09-27 9:10 ` Reimar Döffinger
2021-09-27 9:15 ` Damien Le Moal
2021-10-03 13:28 ` [PATCH v4] Fixes to DMA state check Reimar Döffinger
2021-10-03 13:28 ` [PATCH 1/6] libata: fix checking of DMA state Reimar Döffinger
2021-10-03 13:28 ` [PATCH 2/6] libata-scsi: " Reimar Döffinger
2021-10-03 13:28 ` [PATCH 3/6] pata_ali: " Reimar Döffinger
2021-10-03 13:28 ` Reimar Döffinger [this message]
2021-10-03 13:28 ` [PATCH 5/6] pata_optidma: " Reimar Döffinger
2021-10-03 13:28 ` [PATCH 6/6] pata_radisys: " Reimar Döffinger
2021-10-12 2:20 ` [PATCH v4] Fixes to DMA state check Damien Le Moal
2021-10-12 6:30 ` Reimar Döffinger
[not found] ` <605EE991-5DA2-4A8D-9691-967D68D3AB51@gmx.de>
2021-10-12 6:32 ` Damien Le Moal
2021-10-12 6:33 ` Damien Le Moal
2021-08-15 16:34 ` [PATCH] libata: add kernel parameter to force ATA_HORKAGE_NO_DMA_LOG Reimar Döffinger
2021-10-12 6:27 [PATCH v5] Fixes to DMA state check Reimar Döffinger
2021-10-12 6:27 ` [PATCH 4/6] pata_amd: fix checking of DMA state Reimar Döffinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211003132851.12574-5-Reimar.Doeffinger@gmx.de \
--to=reimar.doeffinger@gmx.de \
--cc=Damien.LeMoal@wdc.com \
--cc=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=pmenzel@molgen.mpg.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).