From: Denis Efremov <efremov@linux.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: "Liu, Chuansheng" <chuansheng.liu@intel.com>,
"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Masahiro Yamada <yamada.masahiro@socionext.com>
Subject: Re: [PATCH] ahci: Remove the exporting of ahci_em_messages
Date: Wed, 14 Aug 2019 00:44:55 +0300 [thread overview]
Message-ID: <340001e6-1750-b6b5-9482-3843679acb63@linux.com> (raw)
In-Reply-To: <27240C0AC20F114CBF8149A2696CBE4A60BCAAEE@SHSMSX106.ccr.corp.intel.com>
Hi Jens,
On 11.07.2019 04:03, Liu, Chuansheng wrote:
>> -----Original Message-----
>> From: Denis Efremov [mailto:efremov@linux.com]
>> Sent: Wednesday, July 10, 2019 11:29 PM
>> To: Liu, Chuansheng <chuansheng.liu@intel.com>
>> Cc: Denis Efremov <efremov@linux.com>; Jens Axboe <axboe@kernel.dk>;
>> linux-ide@vger.kernel.org; linux-kernel@vger.kernel.org
>> Subject: [PATCH] ahci: Remove the exporting of ahci_em_messages
>>
>> The variable ahci_em_messages is declared static and marked
>> EXPORT_SYMBOL_GPL, which is at best an odd combination. Because the
>> variable is not used outside of the drivers/ata/libahci.c file it is
>> defined in, this commit removes the EXPORT_SYMBOL_GPL() marking.
>
> Sounds good to me, thanks.
> Reviewed-by: Chuansheng Liu <chuansheng.liu@linux.intel.com>
>
Could you please look at this patch once again and accept it if it's ok?
static ahci_em_messages will trigger a warning after this check
will be in tree https://lkml.org/lkml/2019/7/14/118
Thanks,
Denis
prev parent reply other threads:[~2019-08-13 21:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-10 15:29 [PATCH] ahci: Remove the exporting of ahci_em_messages Denis Efremov
2019-07-11 1:03 ` Liu, Chuansheng
2019-08-13 21:44 ` Denis Efremov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=340001e6-1750-b6b5-9482-3843679acb63@linux.com \
--to=efremov@linux.com \
--cc=axboe@kernel.dk \
--cc=chuansheng.liu@intel.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).