From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7FB4C4338F for ; Fri, 6 Aug 2021 08:50:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CA58A60F59 for ; Fri, 6 Aug 2021 08:50:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242492AbhHFIu6 (ORCPT ); Fri, 6 Aug 2021 04:50:58 -0400 Received: from smtp-out1.suse.de ([195.135.220.28]:56234 "EHLO smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230119AbhHFIu6 (ORCPT ); Fri, 6 Aug 2021 04:50:58 -0400 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id C30AB21D87; Fri, 6 Aug 2021 08:50:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1628239841; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Tiv29N9YNIMugXo/df4k4cOwWw/RPa85CDse05qvacs=; b=yoHE+0WbPGY96zDEXn+UaSsfy1urGuVt5fzoHC5grB2XjqwWSRoaKExMAMG5vX2amLaA21 C9bJa8RBaPhA0ebV6TpPzLB8FfuFolIuoHVg3PFdOzWD91iIWsFREVwX6Foyox71K4N6D6 snZLp/ggRKnm3OADZWRULa+pfHFH6ik= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1628239841; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Tiv29N9YNIMugXo/df4k4cOwWw/RPa85CDse05qvacs=; b=pQPZG6RQ43MXyl0TLgSopvHYeWNtQFRt05taAgsDaUsnR23bT+y/J0A0zsagIYXm8nD6ae 9u6UY+MHA81VTgDg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B1ABA13A62; Fri, 6 Aug 2021 08:50:41 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 07EXK+H3DGFIZgAAMHmgww (envelope-from ); Fri, 06 Aug 2021 08:50:41 +0000 Subject: Re: [PATCH v2 3/9] libata: cleanup device sleep capability detection To: Damien Le Moal , Jens Axboe , linux-block@vger.kernel.org, linux-ide@vger.kernel.org, "Martin K . Petersen" , linux-scsi@vger.kernel.org Cc: Sathya Prakash , Sreekanth Reddy , Suganath Prabu Subramani References: <20210806074252.398482-1-damien.lemoal@wdc.com> <20210806074252.398482-4-damien.lemoal@wdc.com> From: Hannes Reinecke Message-ID: <3640f64b-f310-c40f-bee9-c568070a0ed7@suse.de> Date: Fri, 6 Aug 2021 10:50:41 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210806074252.398482-4-damien.lemoal@wdc.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org On 8/6/21 9:42 AM, Damien Le Moal wrote: > Move the code to retrieve the device sleep capability and timings out of > ata_dev_configure() into the helper function ata_dev_config_devslp(). > While at it, mark the device as supporting the device sleep capability > only if the sata settings page was retrieved successfully to ensure that > the timing information is correctly initialized. > > Signed-off-by: Damien Le Moal > --- > drivers/ata/libata-core.c | 55 +++++++++++++++++++++++---------------- > 1 file changed, 32 insertions(+), 23 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), GF: Felix Imendörffer