From: Michal Simek <michal.simek@xilinx.com>
To: Piyush Mehta <piyush.mehta@xilinx.com>, <axboe@kernel.dk>
Cc: <linux-ide@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<git@xilinx.com>, <sgoud@xilinx.com>, <michal.simek@xilinx.com>
Subject: Re: [PATCH V2] ata: ahci: ceva: Updated code by using dev_err_probe()
Date: Tue, 6 Apr 2021 16:11:30 +0200 [thread overview]
Message-ID: <6c485429-62a4-608f-6600-4e1f6e88c4e0@xilinx.com> (raw)
In-Reply-To: <20210305091029.23378-1-piyush.mehta@xilinx.com>
Hi Jens,
On 3/5/21 10:10 AM, Piyush Mehta wrote:
> Updated code with already prepared dev_err_probe(). It reduces code size
> and simplifies EPROBE_DEFER handling.
>
> Also, unify message format for similar error cases.
>
> Signed-off-by: Piyush Mehta <piyush.mehta@xilinx.com>
> Acked-by: Michal Simek <michal.simek@xilinx.com>
> ---
> This patch is based on ahci-ceva patches:
> https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git/commit/?h=for-next&id=5542fabd9e07d6c49c07862e73070c325f93d390
>
> Tree: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git/tree/?h=for-next
>
> Changes for V2:
> - Address review comment- remove curly brackets {}.
> ---
> drivers/ata/ahci_ceva.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/ata/ahci_ceva.c b/drivers/ata/ahci_ceva.c
> index b980218..50b56cd 100644
> --- a/drivers/ata/ahci_ceva.c
> +++ b/drivers/ata/ahci_ceva.c
> @@ -206,11 +206,9 @@ static int ceva_ahci_probe(struct platform_device *pdev)
>
> cevapriv->rst = devm_reset_control_get_optional_exclusive(&pdev->dev,
> NULL);
> - if (IS_ERR(cevapriv->rst)) {
> - if (PTR_ERR(cevapriv->rst) != -EPROBE_DEFER)
> - dev_err(&pdev->dev, "failed to get reset: %ld\n",
> - PTR_ERR(cevapriv->rst));
> - }
> + if (IS_ERR(cevapriv->rst))
> + dev_err_probe(&pdev->dev, PTR_ERR(cevapriv->rst),
> + "failed to get reset\n");
>
> hpriv = ahci_platform_get_resources(pdev, 0);
> if (IS_ERR(hpriv))
>
Can you please apply this to your tree?
Thanks,
Michal
next prev parent reply other threads:[~2021-04-06 14:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-05 9:10 [PATCH V2] ata: ahci: ceva: Updated code by using dev_err_probe() Piyush Mehta
2021-04-06 14:11 ` Michal Simek [this message]
2021-04-06 15:25 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c485429-62a4-608f-6600-4e1f6e88c4e0@xilinx.com \
--to=michal.simek@xilinx.com \
--cc=axboe@kernel.dk \
--cc=git@xilinx.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=piyush.mehta@xilinx.com \
--cc=sgoud@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).