linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiri Slaby <jslaby@suse.cz>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>, axboe@kernel.dk
Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org
Subject: Re: [RFC 3/3] ata: sata_mv, avoid trigerrable BUG_ON
Date: Fri, 14 Jun 2019 10:33:01 +0200	[thread overview]
Message-ID: <75a4a778-6862-a0d0-1033-cd5fe57d6dbf@suse.cz> (raw)
In-Reply-To: <0e9f8a3b-65b9-4d87-21f1-684f7e44b166@cogentembedded.com>

On 14. 06. 19, 10:24, Sergei Shtylyov wrote:
>> --- a/drivers/ata/sata_mv.c
>> +++ b/drivers/ata/sata_mv.c
>> @@ -2098,12 +2098,10 @@ static int mv_qc_prep(struct ata_queued_cmd *qc)
>>            * non-NCQ mode are: [RW] STREAM DMA and W DMA FUA EXT, none
>>            * of which are defined/used by Linux.  If we get here, this
>>            * driver needs work.
>> -         *
>> -         * FIXME: modify libata to give qc_prep a return value and
>> -         * return error here.
>>            */
>> -        BUG_ON(tf->command);
>> -        break;
>> +        ata_port_err(ap, "%s: unsupported command: %d\n", __func__,
>> +                tf->command);
> 
>    I'd use "%x" here instead of "%d".

Hi, that makes sense. Fixed locally to %.2x as the commands are defined
as such. Waiting for more comments before [v2] :).

thanks,
-- 
js
suse labs

      reply	other threads:[~2019-06-14  8:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-14  7:11 [RFC 1/3] ata: Documentation, fix function names Jiri Slaby
2019-06-14  7:11 ` [RFC 2/3] ata: make qc_prep return an int Jiri Slaby
2019-06-14  7:11 ` [RFC 3/3] ata: sata_mv, avoid trigerrable BUG_ON Jiri Slaby
2019-06-14  8:24   ` Sergei Shtylyov
2019-06-14  8:33     ` Jiri Slaby [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=75a4a778-6862-a0d0-1033-cd5fe57d6dbf@suse.cz \
    --to=jslaby@suse.cz \
    --cc=axboe@kernel.dk \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sergei.shtylyov@cogentembedded.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).