From: Jens Axboe <axboe@kernel.dk>
To: Sergey Shtylyov <s.shtylyov@omp.ru>, linux-ide@vger.kernel.org
Subject: Re: [PATCH] pata_octeon_cf: avoid WARN_ON() in ata_host_activate()
Date: Tue, 18 May 2021 15:23:45 -0600 [thread overview]
Message-ID: <760bcc25-7dc5-3105-36e7-d55c19ece32b@kernel.dk> (raw)
In-Reply-To: <3a241167-f84d-1d25-5b9b-be910afbe666@omp.ru>
On 5/18/21 2:38 PM, Sergey Shtylyov wrote:
> Iff platform_get_irq() fails (or returns IRQ0) and thus the polling mode
> has to be used, ata_host_activate() hits the WARN_ON() due to 'irq_handler'
> parameter being non-NULL if the polling mode is selected. Let's only set
> the pointer to the driver's IRQ handler if platform_get_irq() returns a
> valid IRQ # -- this should avoid the unnecessary WARN_ON()...
Applied, thanks.
--
Jens Axboe
prev parent reply other threads:[~2021-05-18 21:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-18 20:38 [PATCH] pata_octeon_cf: avoid WARN_ON() in ata_host_activate() Sergey Shtylyov
2021-05-18 21:23 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=760bcc25-7dc5-3105-36e7-d55c19ece32b@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-ide@vger.kernel.org \
--cc=s.shtylyov@omp.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).