From: Jens Axboe <axboe@kernel.dk>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: John Garry <john.garry@huawei.com>,
"open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers)"
<linux-ide@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] libata: Use per port sync for detach
Date: Thu, 18 Jun 2020 09:21:57 -0600 [thread overview]
Message-ID: <88430982-e948-be34-b47b-2411b31eb187@kernel.dk> (raw)
In-Reply-To: <20200603074819.21639-1-kai.heng.feng@canonical.com>
On 6/3/20 1:48 AM, Kai-Heng Feng wrote:
> Commit 130f4caf145c ("libata: Ensure ata_port probe has completed before
> detach") may cause system freeze during suspend.
>
> Using async_synchronize_full() in PM callbacks is wrong, since async
> callbacks that are already scheduled may wait for not-yet-scheduled
> callbacks, causes a circular dependency.
>
> Instead of using big hammer like async_synchronize_full(), use async
> cookie to make sure port probe are synced, without affecting other
> scheduled PM callbacks.
Queued up for 5.8, thanks.
--
Jens Axboe
prev parent reply other threads:[~2020-06-18 15:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-03 7:48 [PATCH v3] libata: Use per port sync for detach Kai-Heng Feng
2020-06-03 8:40 ` John Garry
2020-06-18 5:43 ` Kai-Heng Feng
2020-06-18 15:21 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=88430982-e948-be34-b47b-2411b31eb187@kernel.dk \
--to=axboe@kernel.dk \
--cc=john.garry@huawei.com \
--cc=kai.heng.feng@canonical.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).