From: Max Staudt <max@enpas.org>
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: axboe@kernel.dk, linux-ide@vger.kernel.org,
linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org,
glaubitz@physik.fu-berlin.de, schmitzmic@gmail.com,
geert@linux-m68k.org
Subject: Re: [PATCH v5] ata/pata_buddha: Probe via modalias instead of initcall
Date: Tue, 20 Aug 2019 17:59:47 +0200 [thread overview]
Message-ID: <89894d50-0e3c-4d43-37b2-ff5be407e58c@enpas.org> (raw)
In-Reply-To: <9966f79c-278b-5ec9-3c4b-e1de55af55f0@samsung.com>
Hi Bartlomiej,
Thank you very much for your review!
Question below.
On 08/20/2019 02:06 PM, Bartlomiej Zolnierkiewicz wrote:
>> + /* Workaround for X-Surf: Save drvdata in case zorro8390 has set it */
>> + old_drvdata = dev_get_drvdata(&z->dev);
>
> This should be done only for type == BOARD_XSURF.
Agreed, as I want to keep unloading functional for Buddha/Catweasel - see below.
>> +static struct zorro_driver pata_buddha_driver = {
>> + .name = "pata_buddha",
>> + .id_table = pata_buddha_zorro_tbl,
>> + .probe = pata_buddha_probe,
>> + .remove = pata_buddha_remove,
>
> I think that we should also add:
>
> .driver = {
> .suppress_bind_attrs = true,
> },
>
> to prevent the device from being unbinded (and thus ->remove called)
> from the driver using sysfs interface.
Interesting idea - here's my question now:
My intention is to allow remove() for boards where we support IDE only (Buddha, Catweasel) - these are autoprobed via zorro_register_driver().
This shouldn't affect the X-Surf case, as it's not autoprobed in this way anyway - and thus pata_buddha_driver isn't even used.
Am I missing something? We want to inhibit module unloading (hence no module_exit()), but driver unbinding for Buddha/Catweasel should be fine to remain, right?
> Please also always check your patches with scripts/checkpatch.pl and
> fix the reported issues:
Apologies, must've been something in my coffee. I will.
Thanks for the review, I'll send a new patch once my question above is resolved.
Max
next prev parent reply other threads:[~2019-08-20 15:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20190812164840epcas2p4b88d3ebaf313f0c99ccb693047bce04c@epcas2p4.samsung.com>
2019-08-12 16:48 ` [PATCH v5] ata/pata_buddha: Probe via modalias instead of initcall Max Staudt
2019-08-12 16:51 ` Max Staudt
2019-08-20 12:06 ` Bartlomiej Zolnierkiewicz
2019-08-20 15:59 ` Max Staudt [this message]
2019-08-20 16:54 ` Bartlomiej Zolnierkiewicz
2019-08-20 16:42 ` Max Staudt
2019-08-20 16:55 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89894d50-0e3c-4d43-37b2-ff5be407e58c@enpas.org \
--to=max@enpas.org \
--cc=axboe@kernel.dk \
--cc=b.zolnierkie@samsung.com \
--cc=geert@linux-m68k.org \
--cc=glaubitz@physik.fu-berlin.de \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=schmitzmic@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).