From: Gregory Fong <gregory.0xf0@gmail.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: devicetree@vger.kernel.org,
"Damien Le Moal" <damien.lemoal@opensource.wdc.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
"maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE"
<bcm-kernel-feedback-list@broadcom.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Marc Zyngier" <maz@kernel.org>,
"Ulf Hansson" <ulf.hansson@linaro.org>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Lee Jones" <lee.jones@linaro.org>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Matt Mackall" <mpm@selenic.com>,
"Herbert Xu" <herbert@gondor.apana.org.au>,
"Ray Jui" <rjui@broadcom.com>,
"Scott Branden" <sbranden@broadcom.com>,
"Alessandro Zummo" <a.zummo@towertech.it>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Daniel Lezcano" <daniel.lezcano@linaro.org>,
"Amit Kucheria" <amitk@kernel.org>,
"Zhang Rui" <rui.zhang@intel.com>,
"Markus Mayer" <mmayer@broadcom.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Al Cooper" <alcooperx@gmail.com>,
"Doug Berger" <opendmb@gmail.com>,
"open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers)"
<linux-ide@vger.kernel.org>,
"open list" <linux-kernel@vger.kernel.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
"moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
"open list:MULTIMEDIA CARD (MMC),
SECURE DIGITAL (SD) AND..." <linux-mmc@vger.kernel.org>,
"open list:PWM SUBSYSTEM" <linux-pwm@vger.kernel.org>,
"open list:HARDWARE RANDOM NUMBER GENERATOR CORE"
<linux-crypto@vger.kernel.org>,
"open list:REAL TIME CLOCK (RTC) SUBSYSTEM"
<linux-rtc@vger.kernel.org>,
"open list:THERMAL" <linux-pm@vger.kernel.org>,
"open list:USB SUBSYSTEM" <linux-usb@vger.kernel.org>
Subject: Re: [PATCH 05/14] dt-bindings: gpio: Convert Broadcom STB GPIO to YAML
Date: Thu, 2 Dec 2021 08:00:00 -0800 [thread overview]
Message-ID: <CADtm3G7wiNdDq2fagWeSDd_RV_dyfrNy+5e-VL9OKjwGAWzNtg@mail.gmail.com> (raw)
In-Reply-To: <20211201205110.41656-6-f.fainelli@gmail.com>
Hi Florian,
I haven't kept up with the new yaml format, so not entirely sure I
know what I'm talking about yet, but here are a few comments:
On Wed, Dec 1, 2021 at 12:51 PM Florian Fainelli <f.fainelli@gmail.com> wrote:
>
> Convert the Broadcom STB GPIO Device Tree binding to YAML to help with
> validation.
>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> .../bindings/gpio/brcm,brcmstb-gpio.txt | 83 --------------
> .../bindings/gpio/brcm,brcmstb-gpio.yaml | 104 ++++++++++++++++++
> MAINTAINERS | 2 +-
> 3 files changed, 105 insertions(+), 84 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/gpio/brcm,brcmstb-gpio.txt
> create mode 100644 Documentation/devicetree/bindings/gpio/brcm,brcmstb-gpio.yaml
>
> diff --git a/Documentation/devicetree/bindings/gpio/brcm,brcmstb-gpio.txt b/Documentation/devicetree/bindings/gpio/brcm,brcmstb-gpio.txt
> deleted file mode 100644
> index 5d468ecd1809..000000000000
> --- a/Documentation/devicetree/bindings/gpio/brcm,brcmstb-gpio.txt
> +++ /dev/null
> @@ -1,83 +0,0 @@
> [snip]
> -
> -- interrupts-extended:
> - Alternate form of specifying interrupts and parents that allows for
> - multiple parents. This takes precedence over 'interrupts' and
> - 'interrupt-parent'. Wakeup-capable GPIO controllers often route their
> - wakeup interrupt lines through a different interrupt controller than the
> - primary interrupt line, making this property necessary.
It looks like interrupts-extended was removed from the new docs, I'm
assuming that was intentional?
> [snip]
> diff --git a/Documentation/devicetree/bindings/gpio/brcm,brcmstb-gpio.yaml b/Documentation/devicetree/bindings/gpio/brcm,brcmstb-gpio.yaml
> new file mode 100644
> index 000000000000..4b7309dc74dc
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gpio/brcm,brcmstb-gpio.yaml
> @@ -0,0 +1,104 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/gpio/brcm,brcmstb-gpio.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Broadcom STB "UPG GIO" GPIO controller
> +
> +description: >
> + The controller's registers are organized as sets of eight 32-bit
> + registers with each set controlling a bank of up to 32 pins. A single
> + interrupt is shared for all of the banks handled by the controller.
> +
> +maintainers:
> + - Doug Berger <opendmb@gmail.com>
> + - Florian Fainelli <f.fainelli@gmail.com>
> +
> +properties:
> + compatible:
> + oneOf:
> + - items:
> + - enum:
> + - brcm,bcm7445-gpio
> + - const: brcm,brcmstb-gpio
> +
> + reg:
> + maxItems: 1
> + description:
Missing folded block scalar marker ('>') above
> + Define the base and range of the I/O address space containing
> + the brcmstb GPIO controller registers
> +
> + "#gpio-cells":
> + const: 2
> + description: >
> + The first cell is the pin number (within the controller's
> + pin space), and the second is used for the following:
> + bit[0]: polarity (0 for active-high, 1 for active-low)
> +
> + gpio-controller: true
> +
> + "brcm,gpio-bank-widths":
> + $ref: /schemas/types.yaml#/definitions/uint32-array
> + description:
Same here
> + Number of GPIO lines for each bank. Number of elements must
> + correspond to number of banks suggested by the 'reg' property.
> +
> + interrupts:
> + maxItems: 1
> + description:
While it's not necessary while this is only one line, consider adding
'>' here too.
> + The interrupt shared by all GPIO lines for this controller.
> +
> + "#interrupt-cells":
> + const: 2
> + description: >
This next block could get formatted strangely with '>'; recommend
using '|' instead
> + The first cell is the GPIO number, the second should specify
> + flags. The following subset of flags is supported:
> + - bits[3:0] trigger type and level flags
> + 1 = low-to-high edge triggered
> + 2 = high-to-low edge triggered
> + 4 = active high level-sensitive
> + 8 = active low level-sensitive
> + Valid combinations are 1, 2, 3, 4, 8.
> +
> + interrupt-controller: true
> +
> + wakeup-source:
> + type: boolean
> + description: >
> + GPIOs for this controller can be used as a wakeup source
> +
> +required:
> + - compatible
> + - reg
> + - gpio-controller
> + - "#gpio-cells"
Need to add required property "brcm,gpio-bank-widths"
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + upg_gio: gpio@f040a700 {
> + #gpio-cells = <2>;
> + #interrupt-cells = <2>;
> + compatible = "brcm,bcm7445-gpio", "brcm,brcmstb-gpio";
> + gpio-controller;
> + interrupt-controller;
> + reg = <0xf040a700 0x80>;
> + interrupt-parent = <&irq0_intc>;
> + interrupts = <0x6>;
> + brcm,gpio-bank-widths = <32 32 32 24>;
> + };
> +
> + upg_gio_aon: gpio@f04172c0 {
> + #gpio-cells = <2>;
> + #interrupt-cells = <2>;
> + compatible = "brcm,bcm7445-gpio", "brcm,brcmstb-gpio";
> + gpio-controller;
> + interrupt-controller;
> + reg = <0xf04172c0 0x40>;
> + interrupt-parent = <&irq0_aon_intc>;
> + interrupts = <0x6>;
> + wakeup-source;
> + brcm,gpio-bank-widths = <18 4>;
> + };
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 913856599623..78161abc384f 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -3772,7 +3772,7 @@ BROADCOM BRCMSTB GPIO DRIVER
> M: Gregory Fong <gregory.0xf0@gmail.com>
Not really related to this patch, but I should probably update this
entry to reflect current reality. Should that be you and/or Doug?
> L: bcm-kernel-feedback-list@broadcom.com
> S: Supported
> -F: Documentation/devicetree/bindings/gpio/brcm,brcmstb-gpio.txt
> +F: Documentation/devicetree/bindings/gpio/brcm,brcmstb-gpio.yaml
> F: drivers/gpio/gpio-brcmstb.c
>
> BROADCOM BRCMSTB I2C DRIVER
> --
> 2.25.1
>
Best regards,
Gregory
next prev parent reply other threads:[~2021-12-02 16:01 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-01 20:50 [PATCH 00/14] Broadcom DT bindings updates to YAML Florian Fainelli
2021-12-01 20:50 ` [PATCH 01/14] dt-bindings: mmc: Convert Broadcom STB SDHCI binding " Florian Fainelli
2021-12-01 20:50 ` [PATCH 02/14] dt-bindings: reset: Convert Broadcom STB reset " Florian Fainelli
2021-12-01 20:50 ` [PATCH 03/14] dt-bindings: pwm: Convert BCM7038 PWM binding " Florian Fainelli
2021-12-01 20:51 ` [PATCH 04/14] dt-bindings: rtc: Convert Broadcom STB waketimer " Florian Fainelli
2021-12-01 20:51 ` [PATCH 05/14] dt-bindings: gpio: Convert Broadcom STB GPIO " Florian Fainelli
2021-12-02 16:00 ` Gregory Fong [this message]
2021-12-02 21:24 ` Florian Fainelli
2021-12-01 20:51 ` [PATCH 06/14] dt-binding: interrupt-controller: Convert BCM7038 L1 intc " Florian Fainelli
2021-12-01 20:51 ` [PATCH 07/14] dt-bindings: interrupt-controller: Convert BCM7120 L2 " Florian Fainelli
2021-12-01 20:51 ` [PATCH 08/14] dt-bindings: interrupt-controller: Merge BCM3380 with BCM7120 Florian Fainelli
2021-12-01 20:51 ` [PATCH 09/14] dt-bindings: interrupt-controller: Convert Broadcom STB L2 to YAML Florian Fainelli
2021-12-01 20:51 ` [PATCH 10/14] dt-bindings: rng: Convert iProc RNG200 " Florian Fainelli
2021-12-01 20:51 ` [PATCH 11/14] dt-bindings: thermal: Convert Broadcom TMON " Florian Fainelli
2021-12-01 20:51 ` [PATCH 12/14] dt-bindings: ata: Convert Broadcom SATA " Florian Fainelli
2021-12-01 23:58 ` Damien Le Moal
2021-12-01 20:51 ` [PATCH 13/14] dt-bindings: bus: Convert GISB arbiter " Florian Fainelli
2021-12-01 20:51 ` [PATCH 14/14] dt-bindings: usb: Convert BDC " Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADtm3G7wiNdDq2fagWeSDd_RV_dyfrNy+5e-VL9OKjwGAWzNtg@mail.gmail.com \
--to=gregory.0xf0@gmail.com \
--cc=a.zummo@towertech.it \
--cc=alcooperx@gmail.com \
--cc=alexandre.belloni@bootlin.com \
--cc=amitk@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=brgl@bgdev.pl \
--cc=damien.lemoal@opensource.wdc.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=maz@kernel.org \
--cc=mmayer@broadcom.com \
--cc=mpm@selenic.com \
--cc=opendmb@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=rafael@kernel.org \
--cc=rjui@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
--cc=sbranden@broadcom.com \
--cc=tglx@linutronix.de \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).