From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Tony Asleson <tasleson@redhat.com>
Cc: linux-block@vger.kernel.org, linux-ide@vger.kernel.org,
linux-scsi <linux-scsi@vger.kernel.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Jens Axboe <axboe@kernel.dk>
Subject: Re: [v4 11/11] buffer_io_error: Use durable_name_printk_ratelimited
Date: Sat, 25 Jul 2020 13:29:28 +0300 [thread overview]
Message-ID: <CAHp75VeRzY9wrLpEgi73p=7PEaG9N5iiBAuuys1nY6n4_arFCQ@mail.gmail.com> (raw)
In-Reply-To: <20200724171706.1550403-12-tasleson@redhat.com>
On Fri, Jul 24, 2020 at 8:19 PM Tony Asleson <tasleson@redhat.com> wrote:
>
> Replace printk_ratelimited with one that adds the key/value
> durable name to log entry.
> static void buffer_io_error(struct buffer_head *bh, char *msg)
> {
> - if (!test_bit(BH_Quiet, &bh->b_state))
> - printk_ratelimited(KERN_ERR
> + if (!test_bit(BH_Quiet, &bh->b_state)) {
> + struct device *gendev;
> +
> + gendev = (bh->b_bdev->bd_disk) ?
> + disk_to_dev(bh->b_bdev->bd_disk) : NULL;
Besides unneeded parentheses as Sergey noticed...
> +
> + durable_name_printk_ratelimited(KERN_ERR, gendev,
> "Buffer I/O error on dev %pg, logical block %llu%s\n",
> bh->b_bdev, (unsigned long long)bh->b_blocknr, msg);
> + }
...can we drop indentation level?
if (test_bit(...))
return;
...
> }
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-07-25 10:29 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-24 17:16 [v4 00/11] Add persistent durable identifier to storage log messages Tony Asleson
2020-07-24 17:16 ` [v4 01/11] struct device: Add function callback durable_name Tony Asleson
2020-07-24 17:16 ` [v4 02/11] create_syslog_header: Add durable name Tony Asleson
2020-07-24 17:16 ` [v4 03/11] dev_vprintk_emit: Increase hdr size Tony Asleson
2020-07-25 10:05 ` Andy Shevchenko
2020-08-26 18:26 ` Tony Asleson
2020-07-24 17:16 ` [v4 04/11] scsi: Add durable_name for dev_printk Tony Asleson
2020-07-25 10:20 ` Andy Shevchenko
2020-07-24 17:17 ` [v4 05/11] nvme: Add durable name " Tony Asleson
2020-07-25 9:05 ` Sergei Shtylyov
2020-07-25 10:23 ` Andy Shevchenko
2020-07-24 17:17 ` [v4 06/11] libata: Add ata_scsi_durable_name Tony Asleson
2020-07-25 0:48 ` kernel test robot
2020-07-25 1:07 ` kernel test robot
2020-07-25 1:07 ` [RFC PATCH] libata: ata_scsi_durable_name() can be static kernel test robot
2020-07-25 1:18 ` [v4 06/11] libata: Add ata_scsi_durable_name kernel test robot
2020-07-25 10:26 ` Andy Shevchenko
2020-07-24 17:17 ` [v4 07/11] Add durable_name_printk Tony Asleson
2020-07-24 17:17 ` [v4 08/11] libata: use durable_name_printk Tony Asleson
2020-07-24 17:17 ` [v4 09/11] Add durable_name_printk_ratelimited Tony Asleson
2020-07-24 17:17 ` [v4 10/11] print_req_error: Use durable_name_printk_ratelimited Tony Asleson
2020-07-25 9:15 ` Sergei Shtylyov
2020-07-24 17:17 ` [v4 11/11] buffer_io_error: " Tony Asleson
2020-07-25 10:29 ` Andy Shevchenko [this message]
2020-07-26 15:10 ` [v4 00/11] Add persistent durable identifier to storage log messages Christoph Hellwig
2020-07-27 15:45 ` Tony Asleson
2020-07-27 16:46 ` Hannes Reinecke
2020-07-27 17:42 ` Tony Asleson
2020-07-27 19:17 ` Douglas Gilbert
2020-07-27 20:27 ` Tony Asleson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75VeRzY9wrLpEgi73p=7PEaG9N5iiBAuuys1nY6n4_arFCQ@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=axboe@kernel.dk \
--cc=b.zolnierkie@samsung.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=tasleson@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).