From: Hans de Goede <hdegoede@redhat.com>
To: Alexander Monakov <amonakov@ispras.ru>, Jens Axboe <axboe@kernel.dk>
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
Zhang Rui <rui.zhang@intel.com>,
linux-ide@vger.kernel.org
Subject: Re: AHCI SATA Runtime PM
Date: Wed, 17 Mar 2021 16:02:06 +0100 [thread overview]
Message-ID: <f74cdf09-c08f-5cff-e046-2729aeb703be@redhat.com> (raw)
In-Reply-To: <alpine.LNX.2.20.13.2103041814050.15170@monopod.intra.ispras.ru>
Hi,
On 3/4/21 4:34 PM, Alexander Monakov wrote:
> Hello, Hans, Linux PM folks,
>
> I'm looking for clarification regarding this patch discussion:
>
> https://patchwork.kernel.org/project/linux-pm/patch/20180420101834.15783-2-0v3rdr0n3@gmail.com/
>
> Hans said,
>
>> Ah, so the AHCI code has runtime pm enabled by default (so there
>> is another pm_runtime_allow() somewhere, but then disables it for
>> unused ports to make hotpluging something into those ports work.
>
> I have a laptop where two unused AHCI SATA controllers are present (but
> obviously nothing can be hotplugged into them). Apparently due to the above,
> they do not enter runtime autosuspend.
>
> The problem is, these "ATA port" nodes don't seem to participate in udev
> hierarchy, so it's unclear how I'm supposed to automatically re-enable
> runtime PM for them. For PCI device nodes, I have
>
> ACTION=="add", SUBSYSTEM=="pci", TEST=="power/control", ATTR{power/control}="auto"
>
> but ata1/uevent is empty, so there's no obvious way to write the corresponding
> UDev rule.
You can enable runtime-pm from udev using the following rule:
ACTION=="add", SUBSYSTEM=="ata_port", ATTR{../../power/control}="auto"
> Prior to discovering the above patch discussion, I have filed a bug:
> https://bugzilla.kernel.org/show_bug.cgi?id=211837
>
> Does the above correctly reflect how AHCI PM is supposed to be?
This is a complicated question, I just checked and according to:
https://www.intel.com/content/www/us/en/io/serial-ata/serial-ata-ahci-spec-rev1-3-1.html
AHCI 1.3 compliant controllers should raise a PME signal on hotplug
changes even when in D3. So perhaps the solution is to catch this signal
and then wakeup the controller; and remove the pm_runtime_forbid(dev); call
from ata_tport_add().
I don't have much experience with dealing with the PME stuff, so you will
need to do some research there, or perhaps someone else can help?
This seems to be more of a sata/ahci question then a generic linux-pm question
though, so I have added Jebns and linux-ide to the To / Cc.
> If so, what is
> the proper way to enable runtime PM for unused ATA ports?
Regards,
Hans
parent reply other threads:[~2021-03-17 15:49 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <alpine.LNX.2.20.13.2103041814050.15170@monopod.intra.ispras.ru>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f74cdf09-c08f-5cff-e046-2729aeb703be@redhat.com \
--to=hdegoede@redhat.com \
--cc=amonakov@ispras.ru \
--cc=axboe@kernel.dk \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).