From: Randy Dunlap <rdunlap@infradead.org>
To: Sandeep Singh <Sandeep.Singh@amd.com>,
jikos@kernel.org, benjamin.tissoires@redhat.com,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
srinivas.pandruvada@linux.intel.com, jic23@kernel.org,
linux-iio@vger.kernel.org, hdegoede@redhat.com,
Nehal-bakulchandra.Shah@amd.com, andy.shevchenko@gmail.com,
mail@richard-neumann.de, m.felsch@pengutronix.de
Cc: Shyam-sundar.S-k@amd.com
Subject: Re: [PATCH v7 2/4] SFH: PCIe driver to add support of AMD sensor fusion hub
Date: Mon, 10 Aug 2020 16:03:20 -0700 [thread overview]
Message-ID: <163a507b-1606-f37a-1733-67a06a4dc950@infradead.org> (raw)
In-Reply-To: <20200810213055.103962-3-Sandeep.Singh@amd.com>
On 8/10/20 2:30 PM, Sandeep Singh wrote:
> From: Sandeep Singh <sandeep.singh@amd.com>
>
> AMD SFH uses HID over PCIe bus.SFH fw is part of MP2 processor
> (MP2 which is an ARM® Cortex-M4 core based co-processor to x86) and
> it runs on MP2 where in driver resides on X86. This part of module
> will communicate with MP2 Firmware and provide that data into DRAM
>
> Signed-off-by: Nehal Shah <Nehal-bakulchandra.Shah@amd.com>
> Signed-off-by: Sandeep Singh <sandeep.singh@amd.com>
> ---
> drivers/hid/Kconfig | 2 +
> drivers/hid/Makefile | 2 +
> drivers/hid/amd-sfh-hid/Kconfig | 21 ++++
> drivers/hid/amd-sfh-hid/Makefile | 15 +++
> drivers/hid/amd-sfh-hid/amd_mp2_pcie.c | 164 +++++++++++++++++++++++++
> drivers/hid/amd-sfh-hid/amd_mp2_pcie.h | 83 +++++++++++++
> 6 files changed, 287 insertions(+)
> create mode 100644 drivers/hid/amd-sfh-hid/Kconfig
> create mode 100644 drivers/hid/amd-sfh-hid/Makefile
> create mode 100644 drivers/hid/amd-sfh-hid/amd_mp2_pcie.c
> create mode 100644 drivers/hid/amd-sfh-hid/amd_mp2_pcie.h
>
Hi,
Thanks for the update.
> diff --git a/drivers/hid/amd-sfh-hid/Kconfig b/drivers/hid/amd-sfh-hid/Kconfig
> new file mode 100644
> index 000000000000..a042048e8dd4
> --- /dev/null
> +++ b/drivers/hid/amd-sfh-hid/Kconfig
> @@ -0,0 +1,21 @@
> +# SPDX-License-Identifier: GPL-2.0-or-later
> +menu "AMD SFH HID support"
> + depends on X86_64 || COMPILE_TEST
> + depends on PCI
> + depends on HID
> +
> +config AMD_SFH_HID
> + tristate "AMD Sensor Fusion Hub"
> + help
Sorry I missed this in v6:
help text should be indented with one tab + 2 spaces, so all of this
should be indented an additional 2 spaces.
> + If you say yes to this option, support will be included for the AMD
> + Sensor Fusion Hub.
> + This driver will enable sensors functionality to user through HID
> + framework. Basically this driver will get data from MP2 Firmware
> + and provide that data to HID framework.
> + MP2 which is an ARM® Cortex-M4 core based co-processor to x86.
> +
> + This driver can also be built as a module. If so, the module will
> + be called amd-sfhtp-hid.
> + Say Y or M here if you want to support AMD SFH. If unsure, say N.
> +
> +endmenu
--
~Randy
next prev parent reply other threads:[~2020-08-10 23:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-10 21:30 [PATCH v7 0/4] SFH: Add Support for AMD Sensor Fusion Hub Sandeep Singh
2020-08-10 21:30 ` [PATCH v7 1/4] SFH: Add maintainers and documentation for AMD SFH based on HID framework Sandeep Singh
2020-08-10 23:23 ` Randy Dunlap
2020-08-19 10:23 ` Andy Shevchenko
2020-08-10 21:30 ` [PATCH v7 2/4] SFH: PCIe driver to add support of AMD sensor fusion hub Sandeep Singh
2020-08-10 23:03 ` Randy Dunlap [this message]
2020-08-11 13:54 ` Marco Felsch
2020-08-10 21:30 ` [PATCH v7 3/4] SFH: Transport Driver to add support of AMD Sensor Fusion Hub (SFH) Sandeep Singh
2020-08-19 10:31 ` Andy Shevchenko
2020-08-10 21:30 ` [PATCH v7 4/4] SFH: Create HID report to Enable support of AMD sensor fusion " Sandeep Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=163a507b-1606-f37a-1733-67a06a4dc950@infradead.org \
--to=rdunlap@infradead.org \
--cc=Nehal-bakulchandra.Shah@amd.com \
--cc=Sandeep.Singh@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=andy.shevchenko@gmail.com \
--cc=benjamin.tissoires@redhat.com \
--cc=hdegoede@redhat.com \
--cc=jic23@kernel.org \
--cc=jikos@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.felsch@pengutronix.de \
--cc=mail@richard-neumann.de \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).