linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Matheus Tavares <matheus.bernardino@usp.br>
To: Lars-Peter Clausen <lars@metafoo.de>,
	Michael Hennerich <Michael.Hennerich@analog.com>,
	Jonathan Cameron <jic23@kernel.org>,
	Hartmut Knaack <knaack.h@gmx.de>,
	Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>
Cc: linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Alexandru Ardelean <alexandru.ardelean@analog.com>,
	kernel-usp@googlegroups.com, victorcolombo@gmail.com
Subject: [PATCH v3 2/7] staging:iio:ad2s90: Remove spi setup that should be done via dt
Date: Fri, 23 Nov 2018 22:23:07 -0200	[thread overview]
Message-ID: <20181124002312.6923-3-matheus.bernardino@usp.br> (raw)
In-Reply-To: <20181124002312.6923-1-matheus.bernardino@usp.br>

The ad2s90 driver currently sets some spi settings (max_speed_hz and
mode) at ad2s90_probe. Since the maximum frequency is a required element
in DT binding for spi slave devices and because the spi mode for the
device can be either (0,0) or (1,1), these settings should be handled
via device tree, not in the driver's code. This patch removes them from
the probe function.

Note: The way in which the mentioned spi settings need to be specified
on the ad2s90's node of a device tree will be documented in the future
patch "dt-bindings:iio:resolver: Add docs for ad2s90".

Signed-off-by: Matheus Tavares <matheus.bernardino@usp.br>
---
Changes in v3:
 - none

Changes in v2:
 - Rewritten patch message to better explain why the code snippet in
 question should be removed.

 drivers/staging/iio/resolver/ad2s90.c | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/drivers/staging/iio/resolver/ad2s90.c b/drivers/staging/iio/resolver/ad2s90.c
index fdae067ed866..abb9b9147ee6 100644
--- a/drivers/staging/iio/resolver/ad2s90.c
+++ b/drivers/staging/iio/resolver/ad2s90.c
@@ -77,7 +77,6 @@ static int ad2s90_probe(struct spi_device *spi)
 {
 	struct iio_dev *indio_dev;
 	struct ad2s90_state *st;
-	int ret;
 
 	indio_dev = devm_iio_device_alloc(&spi->dev, sizeof(*st));
 	if (!indio_dev)
@@ -94,16 +93,6 @@ static int ad2s90_probe(struct spi_device *spi)
 	indio_dev->num_channels = 1;
 	indio_dev->name = spi_get_device_id(spi)->name;
 
-	/* need 600ns between CS and the first falling edge of SCLK */
-	spi->max_speed_hz = 830000;
-	spi->mode = SPI_MODE_3;
-	ret = spi_setup(spi);
-
-	if (ret < 0) {
-		dev_err(&spi->dev, "spi_setup failed!\n");
-		return ret;
-	}
-
 	return devm_iio_device_register(indio_dev->dev.parent, indio_dev);
 }
 
-- 
2.18.0

  parent reply	other threads:[~2018-11-24  0:23 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-24  0:23 [PATCH v3 0/7] staging:iio:ad2s90: Add dt support and move out of staging Matheus Tavares
2018-11-24  0:23 ` [PATCH v3 1/7] staging:iio:ad2s90: Add device tree support Matheus Tavares
2018-12-01 15:34   ` Jonathan Cameron
2018-11-24  0:23 ` Matheus Tavares [this message]
2018-12-01 15:34   ` [PATCH v3 2/7] staging:iio:ad2s90: Remove spi setup that should be done via dt Jonathan Cameron
2018-11-24  0:23 ` [PATCH v3 3/7] staging:iio:ad2s90: Add max frequency check at probe Matheus Tavares
2018-12-01 15:37   ` Jonathan Cameron
2018-11-24  0:23 ` [PATCH v3 4/7] dt-bindings:iio:resolver: Add docs for ad2s90 Matheus Tavares
2018-11-27  1:52   ` Rob Herring
2018-12-01 15:37     ` Jonathan Cameron
2018-11-24  0:23 ` [PATCH v3 5/7] staging:iio:ad2s90: Replace license text w/ SPDX identifier Matheus Tavares
2018-12-01 15:38   ` Jonathan Cameron
2018-11-24  0:23 ` [PATCH v3 6/7] staging:iio:ad2s90: Add comment to device state mutex Matheus Tavares
2018-12-01 15:39   ` Jonathan Cameron
2018-11-24  0:23 ` [PATCH v3 7/7] staging:iio:ad2s90: Move out of staging Matheus Tavares
2018-11-25  9:56   ` Jonathan Cameron
2018-11-26  7:34   ` Ardelean, Alexandru
2018-12-01 15:41     ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181124002312.6923-3-matheus.bernardino@usp.br \
    --to=matheus.bernardino@usp.br \
    --cc=Michael.Hennerich@analog.com \
    --cc=alexandru.ardelean@analog.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jic23@kernel.org \
    --cc=kernel-usp@googlegroups.com \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=pmeerw@pmeerw.net \
    --cc=robh+dt@kernel.org \
    --cc=victorcolombo@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).