From: Jonathan Cameron <jic23@kernel.org>
To: Ibtsam Ul-Haq <ibtsam.haq.0x01@gmail.com>
Cc: Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
linux-iio@vger.kernel.org, stefan.popa@analog.com
Subject: Re: [PATCH] iio: Add driver for TLA202x ADCs
Date: Sat, 26 Jan 2019 17:19:58 +0000 [thread overview]
Message-ID: <20190126171958.11808be0@archlinux> (raw)
In-Reply-To: <CAPQseg1q=heJpKPQX-PcPkThHq2NVM1k2tQj1SpUTYTfC=D1Hg@mail.gmail.com>
On Mon, 21 Jan 2019 10:49:17 +0100
Ibtsam Ul-Haq <ibtsam.haq.0x01@gmail.com> wrote:
> Hi,
>
> Thanks a lot for the review. I shall apply all these in the v2, I do
> have just one question, below.
>
> > > > +
> > > > +static int tla2024_of_find_chan(struct tla2024 *priv, struct device_node *ch)
> > > > +{
> > > > + u16 chan_idx = 0;
> > > > + u32 tmp_p, tmp_n;
> > > > + int ainp, ainn;
> > > > + int ret;
> > > > +
> > > > + ret = of_property_read_u32_index(ch, "single-ended", 0, &tmp_p);
> > There is now (only very recently) a generic description in DT for
> > acpi channels. Please look at that:
> >
> > https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git/tree/Documentation/devicetree/bindings/iio/adc/adc.txt?h=togreg&id=00426e99789357dbff7e719a092ce36a3ce49d94
> >
> > It is minimalist. If it is single ended, you can tell that by the absence
> > of diff-channels.
> >
>
> How should we specify which single ended channel to use? For example,
> say I want to configure the driver for reading single-ended values
> only from input pin AIN3. When we only signify a single-ended channel
> by the absence of "diff-channels", where should the "3" be specified?
Fair question. Stefan, what do you think makes sense?
(obviously others welcome but my guess is Stefan has thought about this
more than most ;)
Jonathan
>
> > If the binding needs additional elements (it probably does)
> > then propose them for that generic binding. We are trying to move
> > away from each driver doing it's own thing given all this stuff is
> > pretty generic!
> >
>
> Sorry for trimming the message. Gmail was otherwise blocking my
> outbound message, and I could not find any other way to get it
> through.
>
> Best regards,
> Ibtsam Haq
next prev parent reply other threads:[~2019-01-26 17:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-20 2:10 [PATCH] iio: Add driver for TLA202x ADCs Ibtsam Ul-Haq
2018-11-20 6:11 ` Peter Meerwald-Stadler
2018-11-25 13:01 ` Jonathan Cameron
2019-01-21 9:49 ` Ibtsam Ul-Haq
2019-01-26 17:19 ` Jonathan Cameron [this message]
2019-03-13 11:14 ` [PATCH v2] " Ibtsam Ul-Haq
2019-03-16 14:48 ` Jonathan Cameron
2019-03-22 9:24 ` Ibtsam Ul-Haq
2019-03-24 10:39 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190126171958.11808be0@archlinux \
--to=jic23@kernel.org \
--cc=ibtsam.haq.0x01@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=stefan.popa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).