From: Rob Herring <robh@kernel.org>
To: Ricardo Ribalda Delgado <ricardo@ribalda.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v3 2/2] iio:dac:dac7612: device tree bindings
Date: Wed, 30 Jan 2019 11:07:23 -0600 [thread overview]
Message-ID: <20190130170723.GA24708@bogus> (raw)
In-Reply-To: <20190128094931.4430-2-ricardo@ribalda.com>
On Mon, Jan 28, 2019 at 10:49:31AM +0100, Ricardo Ribalda Delgado wrote:
> Bindings for dac7612.
>
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Ricardo Ribalda Delgado <ricardo@ribalda.com>
> ---
> .../bindings/iio/dac/ti,dac7612.txt | 29 +++++++++++++++++++
> MAINTAINERS | 1 +
> 2 files changed, 30 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/iio/dac/ti,dac7612.txt
>
> diff --git a/Documentation/devicetree/bindings/iio/dac/ti,dac7612.txt b/Documentation/devicetree/bindings/iio/dac/ti,dac7612.txt
> new file mode 100644
> index 000000000000..e1b8158fab35
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/dac/ti,dac7612.txt
> @@ -0,0 +1,29 @@
> +* Texas Instruments Dual, 12-Bit Serial Input Digital-to-Analog Converter
> +
> +The DAC7612 is a dual, 12-bit digital-to-analog converter (DAC) with guaranteed
> +12-bit monotonicity performance over the industrial temperature range.
> +Is is programmable through an SPI interface.
> +
> +The internal DACs are loaded when the LOADDACS pin is pulled down.
> +
> +http://www.ti.com/lit/ds/sbas106/sbas106.pdf
> +
> +Required Properties:
> +- compatible: Should be one of:
> + "ti,dac7612"
> + "ti,dac7612u"
> + "ti,dac7612b"
What's the difference? I can only find 'u' and 'ub' variants and nothing
about how those are different. So maybe just 1 string is enough?
> +- reg: Definition as per Documentation/devicetree/bindings/spi/spi-bus.txt
> +
> +Optional Properties:
> +- loaddacs-gpios: GPIO descriptor for the LOADDACS pin.
Needs a 'ti' vendor prefix.
> +- spi-*: Definition as per Documentation/devicetree/bindings/spi/spi-bus.txt
> +
> +Example:
> +
> + dac7612@1 {
dac@1
> + compatible = "ti,dac7612";
> + reg = <0x1>;
> + loaddacs-gpios = <&msmgpio 25 GPIO_ACTIVE_LOW>;
> + };
> +
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 30ba5435906b..e28e5afaae16 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -14882,6 +14882,7 @@ M: Ricardo Ribalda <ricardo@ribalda.com>
> L: linux-iio@vger.kernel.org
> S: Supported
> F: drivers/iio/dac/ti-dac7612.c
> +F: Documentation/devicetree/bindings/iio/dac/ti,dac7612.txt
>
> THANKO'S RAREMONO AM/FM/SW RADIO RECEIVER USB DRIVER
> M: Hans Verkuil <hverkuil@xs4all.nl>
> --
> 2.20.1
>
next prev parent reply other threads:[~2019-01-30 17:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-28 9:49 [PATCH v3 1/2] iio:dac:ti-dac7612: Add driver for Texas Instruments DAC7612 Ricardo Ribalda Delgado
2019-01-28 9:49 ` [PATCH v3 2/2] iio:dac:dac7612: device tree bindings Ricardo Ribalda Delgado
2019-01-30 17:07 ` Rob Herring [this message]
2019-01-31 14:33 ` Ricardo Ribalda Delgado
2019-01-31 13:48 ` [PATCH v3 1/2] iio:dac:ti-dac7612: Add driver for Texas Instruments DAC7612 Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190130170723.GA24708@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ricardo@ribalda.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).