linux-iio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Vladimir Petrigo <vladimir.petrigo@gmail.com>
Cc: linux-iio@vger.kernel.org, Lars-Peter Clausen <lars@metafoo.de>,
	Michael Hennerich <Michael.Hennerich@analog.com>,
	Hartmut Knaack <knaack.h@gmx.de>,
	Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	devel@driverdev.osuosl.org
Subject: Re: [PATCH v2 2/2] staging: iio: ad7780: Add parentheses to macros
Date: Sun, 24 Mar 2019 16:11:18 +0000	[thread overview]
Message-ID: <20190324161118.6fc4614d@archlinux> (raw)
In-Reply-To: <1553202928-34824-3-git-send-email-vladimir.petrigo@gmail.com>

On Fri, 22 Mar 2019 00:15:28 +0300
Vladimir Petrigo <vladimir.petrigo@gmail.com> wrote:

> - Fix CHECK Macro argument 'wordsize' may be better as '(wordsize)' to avoid precedence issues
> 
> Signed-off-by: Vladimir Petrigo <vladimir.petrigo@gmail.com>

Hi Vladimir,

This particular driver has recently moved out of staging and gained support
for some additional parts.  Still the particular issue was there still.

I applied your patch by hand to the moved driver and the additional case
of the same thing that was write next to this.

Applied to the togreg branch of iio.git and pushed out as testing for the
autobuilders to play with it.

Thanks,

Jonathan

> ---
>  drivers/staging/iio/adc/ad7780.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/iio/adc/ad7780.c b/drivers/staging/iio/adc/ad7780.c
> index c4a8578..010fb47 100644
> --- a/drivers/staging/iio/adc/ad7780.c
> +++ b/drivers/staging/iio/adc/ad7780.c
> @@ -142,7 +142,7 @@ static const struct ad_sigma_delta_info ad7780_sigma_delta_info = {
>  };
>  
>  #define AD7780_CHANNEL(bits, wordsize) \
> -	AD_SD_CHANNEL_NO_SAMP_FREQ(1, 0, 0, bits, 32, wordsize - bits)
> +	AD_SD_CHANNEL_NO_SAMP_FREQ(1, 0, 0, bits, 32, (wordsize) - (bits))
>  
>  static const struct ad7780_chip_info ad7780_chip_info_tbl[] = {
>  	[ID_AD7170] = {


      reply	other threads:[~2019-03-24 16:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-21 21:15 [PATCH v2 0/2] staging: iio: adc: Fix code formatting issues Vladimir Petrigo
2019-03-21 21:15 ` [PATCH v2 1/2] staging: iio: ad7280a: Add parentheses to macros Vladimir Petrigo
2019-03-24 16:04   ` Jonathan Cameron
2019-03-21 21:15 ` [PATCH v2 2/2] staging: iio: ad7780: " Vladimir Petrigo
2019-03-24 16:11   ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190324161118.6fc4614d@archlinux \
    --to=jic23@kernel.org \
    --cc=Michael.Hennerich@analog.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    --cc=vladimir.petrigo@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).