From: Jonathan Cameron <jic23@jic23.retrosnub.co.uk>
To: Alexandre <amergnat@baylibre.com>
Cc: Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
baylibre-upstreaming@groups.io
Subject: Re: [PATCH v2 3/3] iio: Add PAT9125 optical tracker sensor
Date: Sat, 27 Apr 2019 13:11:03 +0100 [thread overview]
Message-ID: <20190427131103.1ce00b1c@archlinux> (raw)
In-Reply-To: <8abd482d-ae1e-ba86-c050-317fc0208fe6@baylibre.com>
On Tue, 23 Apr 2019 16:06:56 +0200
Alexandre <amergnat@baylibre.com> wrote:
> Hi Peter,
>
> On 4/23/19 13:33, Peter Meerwald-Stadler wrote:
> >
> > how is this thing different from a mouse device?
>
> I developed this driver to detect the board movement which can't be
> detected by accelerometer (very slow motion). I admit this use case can
> be handled by an input, and I'm agree with you, PAT9125 driver could be
> an input. But this chip is able to track different kind of motion (flat
> and rotation), and additionally have an interrupt GPIO, so using it like
> input limit the driver potential. This chip is designed to work in
> industrial measurement or embedded systems, and the IIO API match with
> these environments, so IIO is the best way to exploit the entire
> potential of this chip.
>
> As I understand (from
> https://www.kernel.org/doc/html/v4.12/input/event-codes.html#mice ),
> mouse driver must report values when the device move. This feature
> souldn't be mandatory for an optical tracker driver, specially for cases
> where user prefers to use buffer or poll only when he need data.
Given the 'placement' of this driver isn't totally obvious, please
make sure to cc linux-input and Dmitry (maintainer) on V3.
Probably no one will mind, but the last thing we want is someone
else to put forward an input driver and we end up with two drivers
for the same thing.
Thanks,
Jonathan
>
> All other comments will be fixed in V3.
>
> Regards,
>
> Alexandre
>
next prev parent reply other threads:[~2019-04-27 12:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-23 10:40 [PATCH v2 0/3] Add PAT9125 optical tracker driver Alexandre Mergnat
2019-04-23 10:40 ` [PATCH v2 1/3] dt-bindings: Add pixart vendor Alexandre Mergnat
2019-05-17 2:35 ` Rob Herring
2019-04-23 10:40 ` [PATCH v2 2/3] dt-bindings: iio: ot: Add docs pat9125 Alexandre Mergnat
2019-04-23 11:01 ` Peter Meerwald-Stadler
2019-04-23 10:40 ` [PATCH v2 3/3] iio: Add PAT9125 optical tracker sensor Alexandre Mergnat
2019-04-23 11:33 ` Peter Meerwald-Stadler
2019-04-23 14:06 ` Alexandre
2019-04-27 12:11 ` Jonathan Cameron [this message]
2019-04-27 12:52 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190427131103.1ce00b1c@archlinux \
--to=jic23@jic23.retrosnub.co.uk \
--cc=amergnat@baylibre.com \
--cc=baylibre-upstreaming@groups.io \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).